You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Ian Clelland <ic...@chromium.org> on 2013/10/12 04:45:56 UTC
Review Request 14621: Fix plugin JS installation during cordova prepare
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14621/
-----------------------------------------------------------
Review request for cordova and Jeffrey Heifetz.
Bugs: CB-4774
https://issues.apache.org/jira/browse/CB-4774
Repository: cordova-cli
Description
-------
Changes order of operations in `cordova prepare` so that the app www directory is clobbered before plugins are prepared. Without this, the platforms' www directories do not have end up with plugins installed after a `cordova prepare` execution.
Diffs
-----
src/metadata/android_parser.js 2df37e6
src/metadata/blackberry10_parser.js 5ad4f0b
src/metadata/firefoxos_parser.js 51f6e1a
src/metadata/ios_parser.js 15854e8
src/metadata/wp7_parser.js 5bda771
src/metadata/wp8_parser.js ad914b6
src/prepare.js 62dbf65
Diff: https://reviews.apache.org/r/14621/diff/
Testing
-------
Created new mobile spec project:
cordova-cli/bin/cordova create mobilespec com.example.mobilespec mobilespec
cd mobilespec
../cordova-cli/bin/cordova platform add android
../cordova-cli/bin/cordova platform add ios
../cordova-cli/bin/cordova plugin add ../cordova-mobile-spec/dependencies-plugin
rm -r www
ln -s ../cordova-mobile-spec/ www
../cordova-cli/bin/cordova prepare
Checked for existence of platforms/android/assets/www/plugins and platforms/ios/www/plugins.
Ran mobile spec tests on android and ios to verify that plugins were loading correctly.
Other platform parsers are changed to match ios and android, but I don't have hardware to verify the changes.
Thanks,
Ian Clelland
Re: Review Request 14621: Fix plugin JS installation during cordova prepare
Posted by Jeffrey Heifetz <jh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14621/#review26955
-----------------------------------------------------------
Haven't tested it but it looks right to me. I'll try and test over the weekend.
- Jeffrey Heifetz
On Oct. 12, 2013, 2:45 a.m., Ian Clelland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14621/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2013, 2:45 a.m.)
>
>
> Review request for cordova and Jeffrey Heifetz.
>
>
> Bugs: CB-4774
> https://issues.apache.org/jira/browse/CB-4774
>
>
> Repository: cordova-cli
>
>
> Description
> -------
>
> Changes order of operations in `cordova prepare` so that the app www directory is clobbered before plugins are prepared. Without this, the platforms' www directories do not have end up with plugins installed after a `cordova prepare` execution.
>
>
> Diffs
> -----
>
> src/metadata/android_parser.js 2df37e6
> src/metadata/blackberry10_parser.js 5ad4f0b
> src/metadata/firefoxos_parser.js 51f6e1a
> src/metadata/ios_parser.js 15854e8
> src/metadata/wp7_parser.js 5bda771
> src/metadata/wp8_parser.js ad914b6
> src/prepare.js 62dbf65
>
> Diff: https://reviews.apache.org/r/14621/diff/
>
>
> Testing
> -------
>
> Created new mobile spec project:
>
> cordova-cli/bin/cordova create mobilespec com.example.mobilespec mobilespec
> cd mobilespec
> ../cordova-cli/bin/cordova platform add android
> ../cordova-cli/bin/cordova platform add ios
> ../cordova-cli/bin/cordova plugin add ../cordova-mobile-spec/dependencies-plugin
> rm -r www
> ln -s ../cordova-mobile-spec/ www
> ../cordova-cli/bin/cordova prepare
>
> Checked for existence of platforms/android/assets/www/plugins and platforms/ios/www/plugins.
> Ran mobile spec tests on android and ios to verify that plugins were loading correctly.
>
> Other platform parsers are changed to match ios and android, but I don't have hardware to verify the changes.
>
>
> Thanks,
>
> Ian Clelland
>
>
Re: Review Request 14621: Fix plugin JS installation during cordova prepare
Posted by Braden Shepherdson <br...@chromium.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14621/#review27024
-----------------------------------------------------------
Ship it!
Ship It!
- Braden Shepherdson
On Oct. 12, 2013, 2:45 a.m., Ian Clelland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14621/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2013, 2:45 a.m.)
>
>
> Review request for cordova and Jeffrey Heifetz.
>
>
> Bugs: CB-4774
> https://issues.apache.org/jira/browse/CB-4774
>
>
> Repository: cordova-cli
>
>
> Description
> -------
>
> Changes order of operations in `cordova prepare` so that the app www directory is clobbered before plugins are prepared. Without this, the platforms' www directories do not have end up with plugins installed after a `cordova prepare` execution.
>
>
> Diffs
> -----
>
> src/metadata/android_parser.js 2df37e6
> src/metadata/blackberry10_parser.js 5ad4f0b
> src/metadata/firefoxos_parser.js 51f6e1a
> src/metadata/ios_parser.js 15854e8
> src/metadata/wp7_parser.js 5bda771
> src/metadata/wp8_parser.js ad914b6
> src/prepare.js 62dbf65
>
> Diff: https://reviews.apache.org/r/14621/diff/
>
>
> Testing
> -------
>
> Created new mobile spec project:
>
> cordova-cli/bin/cordova create mobilespec com.example.mobilespec mobilespec
> cd mobilespec
> ../cordova-cli/bin/cordova platform add android
> ../cordova-cli/bin/cordova platform add ios
> ../cordova-cli/bin/cordova plugin add ../cordova-mobile-spec/dependencies-plugin
> rm -r www
> ln -s ../cordova-mobile-spec/ www
> ../cordova-cli/bin/cordova prepare
>
> Checked for existence of platforms/android/assets/www/plugins and platforms/ios/www/plugins.
> Ran mobile spec tests on android and ios to verify that plugins were loading correctly.
>
> Other platform parsers are changed to match ios and android, but I don't have hardware to verify the changes.
>
>
> Thanks,
>
> Ian Clelland
>
>
Re: Review Request 14621: Fix plugin JS installation during cordova prepare
Posted by Jeffrey Heifetz <jh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14621/#review27033
-----------------------------------------------------------
Ship it!
Ship It!
- Jeffrey Heifetz
On Oct. 12, 2013, 2:45 a.m., Ian Clelland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14621/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2013, 2:45 a.m.)
>
>
> Review request for cordova and Jeffrey Heifetz.
>
>
> Bugs: CB-4774
> https://issues.apache.org/jira/browse/CB-4774
>
>
> Repository: cordova-cli
>
>
> Description
> -------
>
> Changes order of operations in `cordova prepare` so that the app www directory is clobbered before plugins are prepared. Without this, the platforms' www directories do not have end up with plugins installed after a `cordova prepare` execution.
>
>
> Diffs
> -----
>
> src/metadata/android_parser.js 2df37e6
> src/metadata/blackberry10_parser.js 5ad4f0b
> src/metadata/firefoxos_parser.js 51f6e1a
> src/metadata/ios_parser.js 15854e8
> src/metadata/wp7_parser.js 5bda771
> src/metadata/wp8_parser.js ad914b6
> src/prepare.js 62dbf65
>
> Diff: https://reviews.apache.org/r/14621/diff/
>
>
> Testing
> -------
>
> Created new mobile spec project:
>
> cordova-cli/bin/cordova create mobilespec com.example.mobilespec mobilespec
> cd mobilespec
> ../cordova-cli/bin/cordova platform add android
> ../cordova-cli/bin/cordova platform add ios
> ../cordova-cli/bin/cordova plugin add ../cordova-mobile-spec/dependencies-plugin
> rm -r www
> ln -s ../cordova-mobile-spec/ www
> ../cordova-cli/bin/cordova prepare
>
> Checked for existence of platforms/android/assets/www/plugins and platforms/ios/www/plugins.
> Ran mobile spec tests on android and ios to verify that plugins were loading correctly.
>
> Other platform parsers are changed to match ios and android, but I don't have hardware to verify the changes.
>
>
> Thanks,
>
> Ian Clelland
>
>