You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2024/08/19 20:32:51 UTC
[PR] [Relax] Require correct input/output shapes `R.call_tir` [tvm]
Lunderberg opened a new pull request, #17285:
URL: https://github.com/apache/tvm/pull/17285
Prior to this commit, the Relax well-formed checker validated arguments provided to Relax functions, but did not validate arguments provided to `R.call_tir`. As a result, incorrect arguments from Relax to TIR would not be checked until runtime, if at all.
This commit updates the well-formed checker to verify that `R.call_tir` has received the correct arguments, and has the correct output shape specified in the `out_sinfo` parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax] Require correct input/output shapes `R.call_tir` [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17285:
URL: https://github.com/apache/tvm/pull/17285#issuecomment-2297411321
The implementation in this PR is similar to https://github.com/apache/tvm/pull/17216, but with a few key changes:
* Unlike #17216, this PR raises an error from the well-formed checker if the shape or dtype of `R.call_tir` arguments mismatch.
* Unlike #17216, this PR still requires a user to explicitly provide the `out_sinfo` argument to `R.call_tir`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax] Require correct input/output shapes `R.call_tir` [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17285:
URL: https://github.com/apache/tvm/pull/17285#issuecomment-2310295784
All CI tests are passing, with the exception of the `CI / Windows` step, which has the same failures as seen across all PRs (currently being debugged in https://github.com/apache/tvm/pull/17283). Since the `CI / Windows` is not a required step, this PR is ready for review/merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax] Require correct input/output shapes `R.call_tir` [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17285:
URL: https://github.com/apache/tvm/pull/17285#issuecomment-2329632986
Looks like the failure on `hexagon/pr-head` is due to a timeout, not an error introduced in this PR. Of the 8 shards that run Hexagon unit tests, 7 of them finish in about 1h20m. The 8th node looks like it's being killed after 2 hours, and spends about 50 minutes running `tests/python/contrib/test_hexagon/test_run_unit_tests.py::test_run_unit_tests[]`.
https://github.com/apache/tvm/pull/17334 should resolve the hexagon CI issues by breaking up the single gigantic test, allowing them to be sharded out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax] Require correct input/output shapes `R.call_tir` [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17285:
URL: https://github.com/apache/tvm/pull/17285#issuecomment-2326865352
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax] Require correct input/output shapes `R.call_tir` [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17285:
URL: https://github.com/apache/tvm/pull/17285#issuecomment-2332418755
@tvm-bot rerun
Since #17334 has landed, the hexagon tests should be better spread out across the 8 shards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax] Require correct input/output shapes `R.call_tir` [tvm]
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg merged PR #17285:
URL: https://github.com/apache/tvm/pull/17285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org