You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/28 15:02:07 UTC

[GitHub] [airflow] ericdevries opened a new issue #15575: sqlalchemy connection string with @ in username does not work anymore

ericdevries opened a new issue #15575:
URL: https://github.com/apache/airflow/issues/15575


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   <!--
   
   IMPORTANT!!!
   
   PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
   NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
   
   PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
   
   Please complete the next sections or the issue will be closed.
   These questions are the first thing we need to know to understand the context.
   
   -->
   
   **Apache Airflow version**: 2.0.2
   
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
   1.17.9
   
   **Environment**:
   
   - **Cloud provider or hardware configuration**: azure
   - **OS** (e.g. from /etc/os-release): 
   - **Kernel** (e.g. `uname -a`):
   - **Install tools**:
   - **Others**:
   
   **What happened**:
   
   When starting a pod, the error message says 
   
   ```
   /entrypoint: line 109: BACKEND: unbound variable
   ```
   
   We use an azure-hosted postgres database for the backend, which MUST contain a @ in the username for it to work. The previous versions of airflow handled this just fine. But since the changes in this ticket: https://github.com/apache/airflow/issues/14104 it no longer works because the regex has been changed and now does not accept a @ character in the username.
   
   <!-- (please include exact error messages if you can) -->
   
   **What you expected to happen**:
   
   I expect it to accept a @ in the username
   
   <!-- What do you think went wrong? -->
   
   **How to reproduce it**:
   Start airflow with a connection string like this:
   
   ```
   postgresql://airflow@env:password@env.postgres.database.azure.com:5432/airflow
   ```
   <!---
   
   As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
   
   If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
   
   ## Install minikube/kind
   
   - Minikube https://minikube.sigs.k8s.io/docs/start/
   - Kind https://kind.sigs.k8s.io/docs/user/quick-start/
   
   If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
   
   You can include images using the .md style of
   ![alt text](http://url/to/img.png)
   
   To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
   
   --->
   
   
   **Anything else we need to know**:
   
   <!--
   
   How often does this problem occur? Once? Every time etc?
   
   Any relevant logs to include? Put them here in side a detail tag:
   <details><summary>x.log</summary> lots of stuff </details>
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #15575: sqlalchemy connection string with @ in username does not work anymore

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15575:
URL: https://github.com/apache/airflow/issues/15575#issuecomment-828557244


   For details /specification see here: https://tools.ietf.org/html/rfc3986 
   * '@' is part of gen-delims (type of reserved characters)
   * Userinfo is defined like this: `userinfo    = *( unreserved / pct-encoded / sub-delims / ":" )`  - which means that gen-delims cannot be used, they must b pct-encoded
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ericdevries closed issue #15575: sqlalchemy connection string with @ in username does not work anymore

Posted by GitBox <gi...@apache.org>.
ericdevries closed issue #15575:
URL: https://github.com/apache/airflow/issues/15575


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #15575: sqlalchemy connection string with @ in username does not work anymore

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #15575:
URL: https://github.com/apache/airflow/issues/15575#issuecomment-828528827


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on issue #15575: sqlalchemy connection string with @ in username does not work anymore

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #15575:
URL: https://github.com/apache/airflow/issues/15575#issuecomment-828554593


   Using @ in user name is not allowed by specification see for example here: https://stackoverflow.com/questions/10050877/url-username-with . If the user contains @ you MUST percent-encode it (replace with `%40`) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on issue #15575: sqlalchemy connection string with @ in username does not work anymore

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #15575:
URL: https://github.com/apache/airflow/issues/15575#issuecomment-828554593


   Using @ in user name is not allowed by specification see for example here: https://stackoverflow.com/questions/10050877/url-username-with . If the user contains @ you MUST URL-encode it (replace with `%40`) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #15575: sqlalchemy connection string with @ in username does not work anymore

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15575:
URL: https://github.com/apache/airflow/issues/15575#issuecomment-828554593


   Using @ in user name is not allowed by specification see for example here: https://stackoverflow.com/questions/10050877/url-username-with . If the user contains @ you MUST URL-encode it (replace with %40) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ericdevries commented on issue #15575: sqlalchemy connection string with @ in username does not work anymore

Posted by GitBox <gi...@apache.org>.
ericdevries commented on issue #15575:
URL: https://github.com/apache/airflow/issues/15575#issuecomment-828565712


   Ok, encoding it works, thanks for the advice. I will close this now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org