[GitHub] [cassandra] bdeggleston commented on a diff in pull request #2237: CASSANDRA-18129 Accord <-> Paxos live migration

["bdeggleston (via GitHub)" <gi...@apache.org>]

bdeggleston commented on code in PR #2237:
URL: https://github.com/apache/cassandra/pull/2237#discussion_r1231523097


##########
src/java/org/apache/cassandra/concurrent/SyncFutureTask.java:
##########
@@ -71,7 +71,11 @@ public void run()
         catch (Throwable t)
         {
             tryFailure(t);
-            ExecutionFailure.handle(t);
+            // A lot of exceptions are expected and will be handled by Cassandra
+            // by consuming the result of the future task so only treat Error
+            // as uncaught
+            if (t instanceof Error)

Review Comment:
   >  simulator shouldn't fail on expected exceptions so maybe that is what should change?
   
   That's probably the right thing to do



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org