You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/08/04 15:39:16 UTC
[GitHub] zeppelin pull request #1284: Tagging meta value on interpreter completion.
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1284
Tagging meta value on interpreter completion.
### What is this PR for?
This PR is for showing the meta tag on auto completion.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1291
### How should this be tested?
Please refer to screenshot.
### Screenshots (if appropriate)
- before 1
- before 2
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1291
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1284.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1284
----
commit 4c49432e43c4963b5266044a82d1002cd12931f2
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-04T10:44:02Z
add meta tag on auto completion
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1284: [ZEPPELIN-1291]Tagging meta value on interpreter compl...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1284
@felixcheung Thank you for your review.
I think The meta name of auto completion should be original meta name because the user interpreters name that you mentioned(spark1,spark2) is not related to meta name since the meta name comes from remote interpreter.
And If the meta name of spark is defined ```spark```, auto completion meta name should be ```spark``` even if interpreter group name is ```spark1 or spark2```.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1284: [ZEPPELIN-1291]Tagging meta value on interpreter compl...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1284
Even though the interpreter name is ```spark1``` or ```myintp```, the auto completion is spark's.
so This way(just spark) is clear i think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1284: [ZEPPELIN-1291]Tagging meta value on interprete...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1284
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1284: [ZEPPELIN-1291]Tagging meta value on interpreter compl...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1284
As before, I think it will be more intuitive if in a paragraph, the user types:
```
%hadoop1
spark.
```
And to autocomplete and the popups says `hadoop1`?
Yes, I agree the completion is for "Spark stuff" but completion result might include items that are interpreter instance/state specific things, like local variables and so on?
That said, I don't feel strongly about this so I'll let others to comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1284: [ZEPPELIN-1291]Tagging meta value on interprete...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1284
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1284: [ZEPPELIN-1291]Tagging meta value on interpreter compl...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1284
hmm, shouldn't we match the group name? that's what the user type though (eg. `%spark1`) and auto complete is to help with the user when she's typing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1284: Tagging meta value on interpreter completion.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1284
@AhyoungRyu I fixed. Please review. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1284: [ZEPPELIN-1291]Tagging meta value on interprete...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1284
[ZEPPELIN-1291]Tagging meta value on interpreter completion.
### What is this PR for?
This PR is for showing the meta tag on auto completion.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1291
### How should this be tested?
Please refer to screenshot.
### Screenshots (if appropriate)
- before 1
- before 2
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1291
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1284.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1284
----
commit 4c49432e43c4963b5266044a82d1002cd12931f2
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-04T10:44:02Z
add meta tag on auto completion
commit 78c853aa87a45e52e7e50c6965135819ace3628d
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-05T05:21:58Z
thrift 0.9.2 and add meta description
commit ce86d78c8d3edd2830c31264e836e7218c0b0253
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-18T10:12:25Z
rebase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1284: [ZEPPELIN-1291]Tagging meta value on interpreter compl...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1284
great improvement - would it be better if the tag matches the interpreter name - it could be `%spark1` `%spark2` for example?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1284: [ZEPPELIN-1291]Tagging meta value on interpreter compl...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1284
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1284: Tagging meta value on interpreter completion.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1284
@astroshim Thank you for the prompt fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---