You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/10 20:47:36 UTC
[GitHub] [cordova-android] breautek opened a new pull request #1045: fix: Reflect true minimum required NodeJS
breautek opened a new pull request #1045:
URL: https://github.com/apache/cordova-android/pull/1045
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Fixes #913 (And potentially other issues, however not yet confirmed)
APIs are used that requires a Node minor release of `10.10.0`.
https://github.com/apache/cordova-android/blob/cdcb4ddcd9b9b42facea7460f2f6309a4ac8d6fc/bin/templates/cordova/lib/builders/ProjectBuilder.js#L77
Do note that this is already released in verison `9.0.0`.
### Description
<!-- Describe your changes in detail -->
Increase `package.json` node engine to `>= 10.10.0`
### Testing
<!-- Please describe in detail how you tested your changes. -->
Ran `npm test`.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1045: fix: Reflect true minimum required NodeJS
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1045:
URL: https://github.com/apache/cordova-android/pull/1045#issuecomment-671586302
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=h1) Report
> Merging [#1045](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a45217e6b94e51c7a3de37448084146e44eeca5a&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1045 +/- ##
=======================================
Coverage 69.06% 69.06%
=======================================
Files 20 20
Lines 1833 1833
=======================================
Hits 1266 1266
Misses 567 567
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=footer). Last update [a45217e...7aafc7d](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1045: fix: Reflect true minimum required NodeJS
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1045:
URL: https://github.com/apache/cordova-android/pull/1045#issuecomment-671586302
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=h1) Report
> Merging [#1045](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/a45217e6b94e51c7a3de37448084146e44eeca5a&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1045 +/- ##
==========================================
- Coverage 69.06% 69.01% -0.06%
==========================================
Files 20 20
Lines 1833 1833
==========================================
- Hits 1266 1265 -1
- Misses 567 568 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1045/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.96% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=footer). Last update [a45217e...7aafc7d](https://codecov.io/gh/apache/cordova-android/pull/1045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #1045: fix: Reflect true minimum required NodeJS
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1045:
URL: https://github.com/apache/cordova-android/pull/1045
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org