You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/01/08 12:54:10 UTC

Review Request: SQOOP-643 Implement simple listings for connector and job objects

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8883/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've created simple listing of three basic components - connector, connection and job. Examples:

sqoop:000> show connector 
+----+------------------------+----------------+------------------------------------------------------+
| Id |          Name          |    Version     |                        Class                         |
+----+------------------------+----------------+------------------------------------------------------+
| 1  | generic-jdbc-connector | 2.0.0-SNAPSHOT | org.apache.sqoop.connector.jdbc.GenericJdbcConnector |
+----+------------------------+----------------+------------------------------------------------------+
sqoop:000> show job      
+----+----------+--------+-----------+
| Id |   Name   |  Type  | Connector |
+----+----------+--------+-----------+
| 1  | fist job | IMPORT | 1         |
+----+----------+--------+-----------+
sqoop:000> show connection
+----+-------+-----------+
| Id | Name  | Connector |
+----+-------+-----------+
| 1  | mysql | 1         |
+----+-------+-----------+
sqoop:000>


This addresses bug SQOOP-643.
    https://issues.apache.org/jira/browse/SQOOP-643


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java 8ede0292274abf705bbf9742fdaea067cd4d1ae3 
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 17cb84a71a6833de9e6caef9a020cb2919f7fae0 
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java 6276b3eafa9c12f42c6856fede0e876fb8f6f42a 
  client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java b0780ef48644813a374f37b99832b6e6ded3d6ca 
  client/src/main/java/org/apache/sqoop/client/utils/TableDisplayer.java PRE-CREATION 
  client/src/main/resources/client-resource.properties 7bc7486a29a3663e4926e40c8b8623a829ac010f 

Diff: https://reviews.apache.org/r/8883/diff/


Testing
-------

I've tested it on real cluster, no unit tests provided at the moment.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-643 Implement simple listings for connector and job objects

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8883/
-----------------------------------------------------------

(Updated Jan. 23, 2013, 12:37 a.m.)


Review request for Sqoop.


Changes
-------

I've rebased my patch against current head of sqoop2 branch.


Description
-------

I've created simple listing of three basic components - connector, connection and job. Examples:

sqoop:000> show connector 
+----+------------------------+----------------+------------------------------------------------------+
| Id |          Name          |    Version     |                        Class                         |
+----+------------------------+----------------+------------------------------------------------------+
| 1  | generic-jdbc-connector | 2.0.0-SNAPSHOT | org.apache.sqoop.connector.jdbc.GenericJdbcConnector |
+----+------------------------+----------------+------------------------------------------------------+
sqoop:000> show job      
+----+----------+--------+-----------+
| Id |   Name   |  Type  | Connector |
+----+----------+--------+-----------+
| 1  | fist job | IMPORT | 1         |
+----+----------+--------+-----------+
sqoop:000> show connection
+----+-------+-----------+
| Id | Name  | Connector |
+----+-------+-----------+
| 1  | mysql | 1         |
+----+-------+-----------+
sqoop:000>


This addresses bug SQOOP-643.
    https://issues.apache.org/jira/browse/SQOOP-643


Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java 8ede0292274abf705bbf9742fdaea067cd4d1ae3 
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 8066789a55993d1c533476aa02bdb6beb0c1f912 
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java 6276b3eafa9c12f42c6856fede0e876fb8f6f42a 
  client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 851ddcacbd74a0322c5bf012c6019940f1df9d7d 
  client/src/main/java/org/apache/sqoop/client/utils/TableDisplayer.java PRE-CREATION 
  client/src/main/resources/client-resource.properties 8d6946325ebd2dbe364877c63ddcb7c868cd30bb 

Diff: https://reviews.apache.org/r/8883/diff/


Testing
-------

I've tested it on real cluster, no unit tests provided at the moment.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-643 Implement simple listings for connector and job objects

Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8883/#review15593
-----------------------------------------------------------

Ship it!


This is very cool!

Can you please rebase your patch? It doesn't apply nicely now. Sorry for being late for reviewing it!

- Cheolsoo Park


On Jan. 8, 2013, 11:54 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8883/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 11:54 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've created simple listing of three basic components - connector, connection and job. Examples:
> 
> sqoop:000> show connector 
> +----+------------------------+----------------+------------------------------------------------------+
> | Id |          Name          |    Version     |                        Class                         |
> +----+------------------------+----------------+------------------------------------------------------+
> | 1  | generic-jdbc-connector | 2.0.0-SNAPSHOT | org.apache.sqoop.connector.jdbc.GenericJdbcConnector |
> +----+------------------------+----------------+------------------------------------------------------+
> sqoop:000> show job      
> +----+----------+--------+-----------+
> | Id |   Name   |  Type  | Connector |
> +----+----------+--------+-----------+
> | 1  | fist job | IMPORT | 1         |
> +----+----------+--------+-----------+
> sqoop:000> show connection
> +----+-------+-----------+
> | Id | Name  | Connector |
> +----+-------+-----------+
> | 1  | mysql | 1         |
> +----+-------+-----------+
> sqoop:000>
> 
> 
> This addresses bug SQOOP-643.
>     https://issues.apache.org/jira/browse/SQOOP-643
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 8ede0292274abf705bbf9742fdaea067cd4d1ae3 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 17cb84a71a6833de9e6caef9a020cb2919f7fae0 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java 6276b3eafa9c12f42c6856fede0e876fb8f6f42a 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java b0780ef48644813a374f37b99832b6e6ded3d6ca 
>   client/src/main/java/org/apache/sqoop/client/utils/TableDisplayer.java PRE-CREATION 
>   client/src/main/resources/client-resource.properties 7bc7486a29a3663e4926e40c8b8623a829ac010f 
> 
> Diff: https://reviews.apache.org/r/8883/diff/
> 
> 
> Testing
> -------
> 
> I've tested it on real cluster, no unit tests provided at the moment.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>