You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/08/05 06:58:19 UTC
[jira] Created: (MAVEN-1415) Jar plugin generate incorrect manifest file
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MAVEN-1415
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MAVEN-1415
Summary: Jar plugin generate incorrect manifest file
Type: Bug
Status: Unassigned
Priority: Critical
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven
Versions:
1.0
Assignee:
Reporter: Eugene Kuleshov
Created: Thu, 5 Aug 2004 12:58 AM
Updated: Thu, 5 Aug 2004 12:58 AM
Description:
Current jar plugin genrate an invalid manifest file. In particular it is impossible to retrieve package version information for jars created by this plugin. See more details at http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#JAR%20Manifest
Here is the example of current generated manifest file:
----------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: Apache Maven
Built-By: Administrator
Package: org.codehaus.activemq.jms.cci
Build-Jdk: 1.4.2_02
Class-Path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Extension-Name: ra-jms
Specification-Title:
Specification-Vendor:
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
----------
And this is about how it should look like instead:
------------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: 1.4.2_02-b03 (Sun Microsystems Inc.)
Class-path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Name: org/codehaus/some/component/
Specification-Title: something
Specification-Vendor:
Specification-Version: 0.0.2
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
--------------------------
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MAVEN-1415) Jar plugin generate incorrect manifest file
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Felipe Leme (mailto:jira@felipeal.net)
Date: Fri, 6 Aug 2004 1:22 AM
Comment:
Simple testcase for this issue - I will try to do the fix later...
Changes:
Attachment changed to maven-1415-testcase.zip
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MAVEN-1415?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MAVEN-1415
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MAVEN-1415
Summary: Jar plugin generate incorrect manifest file
Type: Bug
Status: Unassigned
Priority: Critical
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven
Versions:
1.0
Assignee:
Reporter: Eugene Kuleshov
Created: Thu, 5 Aug 2004 12:58 AM
Updated: Fri, 6 Aug 2004 1:22 AM
Description:
Current jar plugin genrate an invalid manifest file. In particular it is impossible to retrieve package version information for jars created by this plugin. See more details at http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#JAR%20Manifest
Here is the example of current generated manifest file:
----------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: Apache Maven
Built-By: Administrator
Package: org.codehaus.activemq.jms.cci
Build-Jdk: 1.4.2_02
Class-Path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Extension-Name: ra-jms
Specification-Title:
Specification-Vendor:
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
----------
And this is about how it should look like instead:
------------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: 1.4.2_02-b03 (Sun Microsystems Inc.)
Class-path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Name: org/codehaus/some/component/
Specification-Title: something
Specification-Vendor:
Specification-Version: 0.0.2
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
--------------------------
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MAVEN-1415) Jar plugin generate incorrect manifest file
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Felipe Leme
Created: Thu, 5 Aug 2004 7:08 AM
Body:
Eugene,
Is there any tool or Java code that could be used to verify if a Jar file is complaint or not? That would make it much easier to test the fix.
Felipe
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MAVEN-1415?page=comments#action_22772
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MAVEN-1415
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MAVEN-1415
Summary: Jar plugin generate incorrect manifest file
Type: Bug
Status: Unassigned
Priority: Critical
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven
Versions:
1.0
Assignee:
Reporter: Eugene Kuleshov
Created: Thu, 5 Aug 2004 12:58 AM
Updated: Thu, 5 Aug 2004 7:08 AM
Description:
Current jar plugin genrate an invalid manifest file. In particular it is impossible to retrieve package version information for jars created by this plugin. See more details at http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#JAR%20Manifest
Here is the example of current generated manifest file:
----------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: Apache Maven
Built-By: Administrator
Package: org.codehaus.activemq.jms.cci
Build-Jdk: 1.4.2_02
Class-Path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Extension-Name: ra-jms
Specification-Title:
Specification-Vendor:
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
----------
And this is about how it should look like instead:
------------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: 1.4.2_02-b03 (Sun Microsystems Inc.)
Class-path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Name: org/codehaus/some/component/
Specification-Title: something
Specification-Vendor:
Specification-Version: 0.0.2
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
--------------------------
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MAVEN-1415) Jar plugin generate incorrect manifest file
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Eugene Kuleshov
Created: Thu, 5 Aug 2004 11:05 AM
Body:
I'm not sure if you can do much automatically.
For the manifest from my original comment if package org/codehaus/some/component/ (notice last slash!) have class MyComponent, then the following code should return true:
"0.0.2".equals( MyComponent.class.getPackage().getSpecificationVersion())
I also noticed that standard jarsigner tool is sometimes picky for incomplete manifests, you can try it too.
Thank you.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MAVEN-1415?page=comments#action_22774
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MAVEN-1415
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MAVEN-1415
Summary: Jar plugin generate incorrect manifest file
Type: Bug
Status: Unassigned
Priority: Critical
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven
Versions:
1.0
Assignee:
Reporter: Eugene Kuleshov
Created: Thu, 5 Aug 2004 12:58 AM
Updated: Thu, 5 Aug 2004 11:05 AM
Description:
Current jar plugin genrate an invalid manifest file. In particular it is impossible to retrieve package version information for jars created by this plugin. See more details at http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#JAR%20Manifest
Here is the example of current generated manifest file:
----------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: Apache Maven
Built-By: Administrator
Package: org.codehaus.activemq.jms.cci
Build-Jdk: 1.4.2_02
Class-Path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Extension-Name: ra-jms
Specification-Title:
Specification-Vendor:
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
----------
And this is about how it should look like instead:
------------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: 1.4.2_02-b03 (Sun Microsystems Inc.)
Class-path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Name: org/codehaus/some/component/
Specification-Title: something
Specification-Vendor:
Specification-Version: 0.0.2
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
--------------------------
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MAVEN-1415) Jar plugin generate incorrect manifest file
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Ian P. Springer
Created: Thu, 5 Aug 2004 9:19 AM
Body:
java.util.jar.Manifest does basic validation of the format. It could always be extended to do more robust validation.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MAVEN-1415?page=comments#action_22773
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MAVEN-1415
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MAVEN-1415
Summary: Jar plugin generate incorrect manifest file
Type: Bug
Status: Unassigned
Priority: Critical
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven
Versions:
1.0
Assignee:
Reporter: Eugene Kuleshov
Created: Thu, 5 Aug 2004 12:58 AM
Updated: Thu, 5 Aug 2004 9:19 AM
Description:
Current jar plugin genrate an invalid manifest file. In particular it is impossible to retrieve package version information for jars created by this plugin. See more details at http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#JAR%20Manifest
Here is the example of current generated manifest file:
----------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: Apache Maven
Built-By: Administrator
Package: org.codehaus.activemq.jms.cci
Build-Jdk: 1.4.2_02
Class-Path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Extension-Name: ra-jms
Specification-Title:
Specification-Vendor:
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
----------
And this is about how it should look like instead:
------------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: 1.4.2_02-b03 (Sun Microsystems Inc.)
Class-path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Name: org/codehaus/some/component/
Specification-Title: something
Specification-Vendor:
Specification-Version: 0.0.2
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
--------------------------
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPJAR-36) Jar plugin generate incorrect manifest file
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Michael Gaffney (mailto:mike@gaffney.cc)
Date: Tue, 5 Oct 2004 1:55 PM
Comment:
I've attached a patch to fix this problem. I moved version information about a package from the 'main' manifest section to a package section. I looked at manifest files for other projects (like ant and xalan) and noticed they were also doing it this way. An added benefit is that it would now be possible to correctly merge two jar files and their manifest files.
I deleted the setting of the 'Created-By' attribute because the ant manifest task correctly sets this with the java version used to generate the manifest file (which is what the Sun spec says it should be). This info was previously captured in the non-standard 'Build-Jdk' attribute which I removed because it was redundant.
Changes:
Attachment changed to patch.txt
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPJAR-36?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJAR-36
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJAR-36
Summary: Jar plugin generate incorrect manifest file
Type: Bug
Status: Unassigned
Priority: Critical
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jar-plugin
Versions:
1.5
Assignee:
Reporter: Eugene Kuleshov
Created: Thu, 5 Aug 2004 12:58 AM
Updated: Tue, 5 Oct 2004 1:55 PM
Description:
Current jar plugin genrate an invalid manifest file. In particular it is impossible to retrieve package version information for jars created by this plugin. See more details at http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#JAR%20Manifest
Here is the example of current generated manifest file:
----------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: Apache Maven
Built-By: Administrator
Package: org.codehaus.activemq.jms.cci
Build-Jdk: 1.4.2_02
Class-Path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Extension-Name: ra-jms
Specification-Title:
Specification-Vendor:
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
----------
And this is about how it should look like instead:
------------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: 1.4.2_02-b03 (Sun Microsystems Inc.)
Class-path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Name: org/codehaus/some/component/
Specification-Title: something
Specification-Vendor:
Specification-Version: 0.0.2
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
--------------------------
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPJAR-36) Jar plugin generate incorrect manifest file
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Eugene Kuleshov (mailto:eu@platonoff.com)
Date: Sat, 14 Aug 2004 12:43 PM
Comment:
complete Eclipse prject to demonstrate usage of the Package API
Changes:
Attachment changed to jartest.zip
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPJAR-36?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJAR-36
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJAR-36
Summary: Jar plugin generate incorrect manifest file
Type: Bug
Status: Unassigned
Priority: Critical
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jar-plugin
Versions:
1.5
Assignee:
Reporter: Eugene Kuleshov
Created: Thu, 5 Aug 2004 12:58 AM
Updated: Sat, 14 Aug 2004 12:43 PM
Description:
Current jar plugin genrate an invalid manifest file. In particular it is impossible to retrieve package version information for jars created by this plugin. See more details at http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#JAR%20Manifest
Here is the example of current generated manifest file:
----------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: Apache Maven
Built-By: Administrator
Package: org.codehaus.activemq.jms.cci
Build-Jdk: 1.4.2_02
Class-Path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Extension-Name: ra-jms
Specification-Title:
Specification-Vendor:
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
----------
And this is about how it should look like instead:
------------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: 1.4.2_02-b03 (Sun Microsystems Inc.)
Class-path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Name: org/codehaus/some/component/
Specification-Title: something
Specification-Vendor:
Specification-Version: 0.0.2
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
--------------------------
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJAR-36) Jar plugin generate incorrect manifest file
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Felipe Leme
Created: Fri, 13 Aug 2004 8:25 PM
Body:
Eugene,
I couldn't get the package information from any jar that I tested. Could you please attach a jar where your code snippet works? Better yet if it has a main class that already test it.
Felipe
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJAR-36?page=comments#action_23087
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJAR-36
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJAR-36
Summary: Jar plugin generate incorrect manifest file
Type: Bug
Status: Unassigned
Priority: Critical
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jar-plugin
Versions:
1.5
Assignee:
Reporter: Eugene Kuleshov
Created: Thu, 5 Aug 2004 12:58 AM
Updated: Fri, 13 Aug 2004 8:25 PM
Description:
Current jar plugin genrate an invalid manifest file. In particular it is impossible to retrieve package version information for jars created by this plugin. See more details at http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#JAR%20Manifest
Here is the example of current generated manifest file:
----------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: Apache Maven
Built-By: Administrator
Package: org.codehaus.activemq.jms.cci
Build-Jdk: 1.4.2_02
Class-Path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Extension-Name: ra-jms
Specification-Title:
Specification-Vendor:
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
----------
And this is about how it should look like instead:
------------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: 1.4.2_02-b03 (Sun Microsystems Inc.)
Class-path: commons-logging-1.0.3.jar log4j-1.2.8.jar
Name: org/codehaus/some/component/
Specification-Title: something
Specification-Vendor:
Specification-Version: 0.0.2
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor:
Implementation-Version: 0.0.2
--------------------------
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org