You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Konrad Windszus (JIRA)" <ji...@apache.org> on 2018/08/28 09:14:00 UTC

[jira] [Commented] (JCRVLT-268) filevaultMavenPlugin: scanning for oak index does not work on windows systems

    [ https://issues.apache.org/jira/browse/JCRVLT-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594733#comment-16594733 ] 

Konrad Windszus commented on JCRVLT-268:
----------------------------------------

I provided a PR in https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/17. [~tripod] Can you quickly cross-check?

> filevaultMavenPlugin: scanning for oak index does not work on windows systems
> -----------------------------------------------------------------------------
>
>                 Key: JCRVLT-268
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-268
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: package maven plugin
>            Reporter: Lukas Kummer
>            Priority: Minor
>         Attachments: screenshot-windows.png
>
>
> on windows systems oak indexes are always added to the filter, and allowIndexDefinitions has no effect. The reason for this is a static String comparison in class FileValidator ~Line 72:
> {code:java}
> } else if ("META-INF/vault/filter.xml".equals(artifactName) || artifactName.contains("/_oak_index/")) {
> {code}
> See attached screenshot, why comparison fails on Windows:
> !screenshot-windows.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)