You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/03 13:27:15 UTC

[GitHub] [rocketmq] Jason918 commented on a change in pull request #3337: [ISSUE #3359] Add function--Custom delay time

Jason918 commented on a change in pull request #3337:
URL: https://github.com/apache/rocketmq/pull/3337#discussion_r741934726



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java
##########
@@ -212,10 +212,10 @@ public static BrokerController createBrokerController(String[] args) {
             MixAll.printObjectProperties(log, messageStoreConfig);
 
             final BrokerController controller = new BrokerController(
-                brokerConfig,
-                nettyServerConfig,
-                nettyClientConfig,
-                messageStoreConfig);
+                    brokerConfig,

Review comment:
       It seems that only the indention is changed in this file. 
   IMHO, It's better keep as it is, because it will change the log history, and it will be confusing if someone want to check the implementation details through the git log.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org