You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/03 18:59:21 UTC

[GitHub] [arrow-cookbook] Nlte opened a new pull request #2: Explicit arr object creation

Nlte opened a new pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2


   Hi, I have started playing with the cookbook examples and there is a little doc section that I did not find clear hence here this PR.
   
   ### Issue
   The **testsetup::** blocs in the rst files are not written out in the resulting HTML.
   In the "Given an array with 100 numbers, from 0 to 99" sections the **arr** object pops up ex nihilo in the documentation which might lose the reader a bit even though most people will guess the np.arange here.
   
   ### Proposed solution
   Add the array creation code in the testcode:: blocs for those sections section to make it more explicit.
   
   That is going from
   ```
   Given an array with 100 numbers, from 0 to 99
   
   print(f"{arr[0]} .. {arr[-1]}")
   
   0 .. 99
   ```
   
   to
   
   ```
   Given an array with 100 numbers, from 0 to 99
   
   import numpy as np
   import pyarrow as pa
   
   arr = pa.array(np.arange(100))
   
   print(f"{arr[0]} .. {arr[-1]}")
   
   0 .. 99
   ```
   
   Thanks,
   Nathanaël
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-cookbook] westonpace merged pull request #2: Explicit arr object creation

Posted by GitBox <gi...@apache.org>.
westonpace merged pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-cookbook] Nlte commented on pull request #2: Explicit arr object creation

Posted by GitBox <gi...@apache.org>.
Nlte commented on pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2#issuecomment-896953217


   I think we still need the `testsetup` code for the intermediate cell tests to pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-cookbook] thisisnic commented on pull request #2: Explicit arr object creation

Posted by GitBox <gi...@apache.org>.
thisisnic commented on pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2#issuecomment-894073766


   FYI, I think amol- is on vacation for another week or so, so this won't get looked at til then


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-cookbook] westonpace merged pull request #2: Explicit arr object creation

Posted by GitBox <gi...@apache.org>.
westonpace merged pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-cookbook] westonpace commented on pull request #2: Explicit arr object creation

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2#issuecomment-900514057






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-cookbook] westonpace commented on pull request #2: Explicit arr object creation

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2#issuecomment-893280029


   @amol- mind taking a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-cookbook] westonpace commented on pull request #2: Explicit arr object creation

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2#issuecomment-900800197


   Merging.  @Nlte Thank you very much for the contribution!  Feel free to add any other ideas.  This project is just getting started so the more input the better :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-cookbook] westonpace commented on pull request #2: Explicit arr object creation

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2#issuecomment-900514057


   @amol- any thoughts on this?  Otherwise I'll go ahead and merge this evening.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-cookbook] westonpace commented on pull request #2: Explicit arr object creation

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2#issuecomment-893280029


   @amol- mind taking a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-cookbook] jorisvandenbossche commented on pull request #2: Explicit arr object creation

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #2:
URL: https://github.com/apache/arrow-cookbook/pull/2#issuecomment-896002080


   I had the same observation while going through the IO cookbook: I think it would indeed be nice that the example is fully reproducible (copy/pastable), and thus includes the code to create the dummy data.
   
   The same code in the `testsetup` could then be removed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org