You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Maxim Muzafarov <ma...@gmail.com> on 2019/07/18 11:29:17 UTC
[DISCUSSION] Remove preload predicate in GridCachePreloader
Igniters,
It seems to me that GridCachePreloader.preloadPredicate(); currently
not used and even not tested at all and can be removed. Can anyone
confirm that?
I see the following disadvantages here:
- not used in project code, not tested;
- mvcc preload entry doesn't use this filter (regular preload entry does);
- a bit strange removing any entries on rebalancing under the hood, it
can lead to data inconsistency
I've created the issue [1] and PR [2] with removing such methods (bot
visa green).
WDYT?
[1] https://issues.apache.org/jira/browse/IGNITE-11989
[2] https://github.com/apache/ignite/pull/6699/files
Re: [DISCUSSION] Remove preload predicate in GridCachePreloader
Posted by Pavel Kovalenko <jo...@gmail.com>.
Maxim,
Go ahead. I don't see any real usages of this functionality and seems it
obsolete and should be removed.
пт, 19 июл. 2019 г. в 08:36, Anton Vinogradov <av...@apache.org>:
> Folks,
>
> To be clear, I'm going to merge the PR next Monday in case of interest lack
> (which means the feature is obsolete and can be removed).
>
> On Thu, Jul 18, 2019 at 2:29 PM Maxim Muzafarov <ma...@gmail.com>
> wrote:
>
> > Igniters,
> >
> > It seems to me that GridCachePreloader.preloadPredicate(); currently
> > not used and even not tested at all and can be removed. Can anyone
> > confirm that?
> >
> > I see the following disadvantages here:
> > - not used in project code, not tested;
> > - mvcc preload entry doesn't use this filter (regular preload entry
> does);
> > - a bit strange removing any entries on rebalancing under the hood, it
> > can lead to data inconsistency
> >
> > I've created the issue [1] and PR [2] with removing such methods (bot
> > visa green).
> > WDYT?
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-11989
> > [2] https://github.com/apache/ignite/pull/6699/files
> >
>
Re: [DISCUSSION] Remove preload predicate in GridCachePreloader
Posted by Anton Vinogradov <av...@apache.org>.
Folks,
To be clear, I'm going to merge the PR next Monday in case of interest lack
(which means the feature is obsolete and can be removed).
On Thu, Jul 18, 2019 at 2:29 PM Maxim Muzafarov <ma...@gmail.com> wrote:
> Igniters,
>
> It seems to me that GridCachePreloader.preloadPredicate(); currently
> not used and even not tested at all and can be removed. Can anyone
> confirm that?
>
> I see the following disadvantages here:
> - not used in project code, not tested;
> - mvcc preload entry doesn't use this filter (regular preload entry does);
> - a bit strange removing any entries on rebalancing under the hood, it
> can lead to data inconsistency
>
> I've created the issue [1] and PR [2] with removing such methods (bot
> visa green).
> WDYT?
>
> [1] https://issues.apache.org/jira/browse/IGNITE-11989
> [2] https://github.com/apache/ignite/pull/6699/files
>