[GitHub] spark pull request #19383: [SPARK-20643][core] Add listener implementation t...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19383#discussion_r142203766
  
    --- Diff: common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDB.java ---
    @@ -76,7 +76,7 @@ public LevelDB(File path, KVStoreSerializer serializer) throws Exception {
         this.types = new ConcurrentHashMap<>();
     
         Options options = new Options();
    -    options.createIfMissing(!path.exists());
    +    options.createIfMissing(true);
    --- End diff --
    
    Tests generally use a temp dir for the db, using `Utils.createTempDir` or something like that which creates the directory for you. That would cause this to fail unless you deleted the directory first (which `LevelDBSuite` does), which I found a little bit annoying after a while.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org