You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/10/30 05:52:44 UTC
[GitHub] [lucenenet] sachdevlaksh opened a new pull request, #730: Sonar changes required for #671
sachdevlaksh opened a new pull request, #730:
URL: https://github.com/apache/lucenenet/pull/730
Added changes for #671 to remove empty line sonar warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] sachdevlaksh commented on pull request #730: Sonar changes required for #671
Posted by GitBox <gi...@apache.org>.
sachdevlaksh commented on PR #730:
URL: https://github.com/apache/lucenenet/pull/730#issuecomment-1296179487
> Thanks for the PR. Looks pretty good, but there were a couple of flagged issues that were missed and one that needs to be changed (see the comment inline).
>
> * [HyphenationTree.cs](https://sonarcloud.io/project/issues?issues=AYPAuPQshbfJOGLOoa_p&open=AYPAuPQshbfJOGLOoa_p&id=nikcio_lucenenet)
> * [BasqueStemmer.cs](https://sonarcloud.io/project/issues?issues=AYPAuPnchbfJOGLOobMP&open=AYPAuPnchbfJOGLOobMP&id=nikcio_lucenenet)
>
> For future reference, please adjust your editor so it doesn't change whitespace characters when you edit. It takes a lot longer to review when there are dozens of whitespace edits in the file and only a handful of "real" changed lines. No need to revert whitespace changes on this PR.
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] sachdevlaksh commented on a diff in pull request #730: Sonar changes required for #671
Posted by GitBox <gi...@apache.org>.
sachdevlaksh commented on code in PR #730:
URL: https://github.com/apache/lucenenet/pull/730#discussion_r1008817825
##########
src/Lucene.Net.Analysis.Common/Tartarus/Snowball/Ext/TurkishStemmer.cs:
##########
@@ -2207,7 +2207,7 @@ private bool r_stem_suffix_chain_before_ki()
lab18:
goto lab15;
} while (false);
- lab17:
+ lab17: {/* LUCENENET: intentionally blank */}
Review Comment:
Thanks for the review. I will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on a diff in pull request #730: Sonar changes required for #671
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on code in PR #730:
URL: https://github.com/apache/lucenenet/pull/730#discussion_r1008804054
##########
src/Lucene.Net.Analysis.Common/Tartarus/Snowball/Ext/TurkishStemmer.cs:
##########
@@ -2207,7 +2207,7 @@ private bool r_stem_suffix_chain_before_ki()
lab18:
goto lab15;
} while (false);
- lab17:
+ lab17: {/* LUCENENET: intentionally blank */}
Review Comment:
This block is not blank, so we don't need a comment or curly brackets here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 merged pull request #730: Sonar changes required for #671
Posted by GitBox <gi...@apache.org>.
NightOwl888 merged PR #730:
URL: https://github.com/apache/lucenenet/pull/730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org