You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Axel Delahaye <ax...@worldline.com> on 2014/04/03 18:51:58 UTC
Re: Review Request 16688: console-proxy add support of AltGr key and FR
azerty keyboard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16688/
-----------------------------------------------------------
(Updated April 3, 2014, 4:51 p.m.)
Review request for cloudstack.
Changes
-------
I added the '<' and '>' char to the french keyboard for console proxy
Repository: cloudstack-git
Description
-------
Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in ajaxviwer.js.
altgr : <altgr state match condition>, -- match on altgr state
It works like the shift match condition.
shift : <shift state match condition>, -- match on shift state
Browser can't detect difference between AltGr and Ctrl+Alt pressed at the same time.
So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr key and 'altgr' condition will be true.
In the ajaxkey.js file you got for example:
{type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true}
to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key
Secondly,
I wrote the French AZERTY translation table in ajaxkeys.js with the support of AltGr character (like #{}[]|,etc.)
For example the '#':
{keycode: 51, entry: [ //User type the "3# key and each condition match 'altgr'
{type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC AltGR key
{type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true}, //press the 3 key
{type: KEY_UP, code: 0x33, modifiers: 0, altgr: true}, //release it
{type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true} //release the AltGr key
]},
I replace the Standard (US) keyboard translation table because I can't add an entry in the console proxy keyboard menu.
Thanks for watching my work
Axel Delahaye
Diffs (updated)
-----
services/console-proxy/server/js/ajaxkeys.js abe6f13
Diff: https://reviews.apache.org/r/16688/diff/
Testing
-------
Tested with
Hardware : French AZERTY keyboard
Software : Configured in windows as FR keyboard
Console-proxy : Customized Standard (US) keyboard
Guest : CentOS 6.5 , Debian 7 and FreeBSD 8
Guest keymap : fr, fr-pc
Only the "<" ">" key doesn't work
Thanks,
Axel Delahaye
Re: Review Request 16688: console-proxy add support of AltGr key and FR
azerty keyboard
Posted by Axel Delahaye <ax...@worldline.com>.
> On April 9, 2014, 1:54 p.m., daan Hoogland wrote:
> > Axel,
> >
> > 4.2 will not be worked on anymore. You can create a patched version for yourself if you need to. Next release will be either 4.3.1, 4.4.0 or 5.0.0
> >
> > Also please submit a seperate review request for another branch if you need to have a patch ported.
Done : https://reviews.apache.org/r/20078/
Thank you for feedback
- Axel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16688/#review39885
-----------------------------------------------------------
On April 3, 2014, 4:51 p.m., Axel Delahaye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16688/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 4:51 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in ajaxviwer.js.
> altgr : <altgr state match condition>, -- match on altgr state
>
> It works like the shift match condition.
> shift : <shift state match condition>, -- match on shift state
>
> Browser can't detect difference between AltGr and Ctrl+Alt pressed at the same time.
> So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr key and 'altgr' condition will be true.
>
> In the ajaxkey.js file you got for example:
> {type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true}
> to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key
>
> Secondly,
> I wrote the French AZERTY translation table in ajaxkeys.js with the support of AltGr character (like #{}[]|,etc.)
>
> For example the '#':
>
> {keycode: 51, entry: [ //User type the "3# key and each condition match 'altgr'
> {type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC AltGR key
> {type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true}, //press the 3 key
> {type: KEY_UP, code: 0x33, modifiers: 0, altgr: true}, //release it
> {type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true} //release the AltGr key
> ]},
>
> I replace the Standard (US) keyboard translation table because I can't add an entry in the console proxy keyboard menu.
>
> Thanks for watching my work
>
> Axel Delahaye
>
>
> Diffs
> -----
>
> services/console-proxy/server/js/ajaxkeys.js abe6f13
>
> Diff: https://reviews.apache.org/r/16688/diff/
>
>
> Testing
> -------
>
> Tested with
> Hardware : French AZERTY keyboard
> Software : Configured in windows as FR keyboard
> Console-proxy : Customized Standard (US) keyboard
> Guest : CentOS 6.5 , Debian 7 and FreeBSD 8
> Guest keymap : fr, fr-pc
>
> Only the "<" ">" key doesn't work
>
>
> Thanks,
>
> Axel Delahaye
>
>
Re: Review Request 16688: console-proxy add support of AltGr key and FR
azerty keyboard
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16688/#review39885
-----------------------------------------------------------
Axel,
4.2 will not be worked on anymore. You can create a patched version for yourself if you need to. Next release will be either 4.3.1, 4.4.0 or 5.0.0
Also please submit a seperate review request for another branch if you need to have a patch ported.
- daan Hoogland
On April 3, 2014, 4:51 p.m., Axel Delahaye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16688/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 4:51 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in ajaxviwer.js.
> altgr : <altgr state match condition>, -- match on altgr state
>
> It works like the shift match condition.
> shift : <shift state match condition>, -- match on shift state
>
> Browser can't detect difference between AltGr and Ctrl+Alt pressed at the same time.
> So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr key and 'altgr' condition will be true.
>
> In the ajaxkey.js file you got for example:
> {type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true}
> to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key
>
> Secondly,
> I wrote the French AZERTY translation table in ajaxkeys.js with the support of AltGr character (like #{}[]|,etc.)
>
> For example the '#':
>
> {keycode: 51, entry: [ //User type the "3# key and each condition match 'altgr'
> {type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC AltGR key
> {type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true}, //press the 3 key
> {type: KEY_UP, code: 0x33, modifiers: 0, altgr: true}, //release it
> {type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true} //release the AltGr key
> ]},
>
> I replace the Standard (US) keyboard translation table because I can't add an entry in the console proxy keyboard menu.
>
> Thanks for watching my work
>
> Axel Delahaye
>
>
> Diffs
> -----
>
> services/console-proxy/server/js/ajaxkeys.js abe6f13
>
> Diff: https://reviews.apache.org/r/16688/diff/
>
>
> Testing
> -------
>
> Tested with
> Hardware : French AZERTY keyboard
> Software : Configured in windows as FR keyboard
> Console-proxy : Customized Standard (US) keyboard
> Guest : CentOS 6.5 , Debian 7 and FreeBSD 8
> Guest keymap : fr, fr-pc
>
> Only the "<" ">" key doesn't work
>
>
> Thanks,
>
> Axel Delahaye
>
>
Re: Review Request 16688: console-proxy add support of AltGr key and
FR azerty keyboard
Posted by Daan Hoogland <da...@gmail.com>.
Axel, did you change this already submitted change request? Or did you
reuse the entry in the review boar to create a new review request? In both
cases I'd rather have you close this one and create a new one.
On Thu, Apr 3, 2014 at 6:51 PM, Axel Delahaye
<ax...@worldline.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16688/
> Review request for cloudstack.
> By Axel Delahaye.
>
> *Updated April 3, 2014, 4:51 p.m.*
> Changes
>
> I added the '<' and '>' char to the french keyboard for console proxy
>
> *Repository: * cloudstack-git
> Description
>
> Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in ajaxviwer.js.
> altgr : <altgr state match condition>, -- match on altgr state
>
> It works like the shift match condition.
> shift : <shift state match condition>, -- match on shift state
>
> Browser can't detect difference between AltGr and Ctrl+Alt pressed at the same time.
> So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr key and 'altgr' condition will be true.
>
> In the ajaxkey.js file you got for example:
> {type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true}
> to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key
>
> Secondly,
> I wrote the French AZERTY translation table in ajaxkeys.js with the support of AltGr character (like #{}[]|,etc.)
>
> For example the '#':
>
> {keycode: 51, entry: [ //User type the "3# key and each condition match 'altgr'
> {type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC AltGR key
> {type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true}, //press the 3 key
> {type: KEY_UP, code: 0x33, modifiers: 0, altgr: true}, //release it
> {type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true} //release the AltGr key
> ]},
>
> I replace the Standard (US) keyboard translation table because I can't add an entry in the console proxy keyboard menu.
>
> Thanks for watching my work
>
> Axel Delahaye
>
> Testing
>
> Tested with
> Hardware : French AZERTY keyboard
> Software : Configured in windows as FR keyboard
> Console-proxy : Customized Standard (US) keyboard
> Guest : CentOS 6.5 , Debian 7 and FreeBSD 8
> Guest keymap : fr, fr-pc
>
> Only the "<" ">" key doesn't work
>
> Diffs (updated)
>
> - services/console-proxy/server/js/ajaxkeys.js (abe6f13)
>
> View Diff <https://reviews.apache.org/r/16688/diff/>
>
--
Daan