You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/17 13:55:35 UTC
[GitHub] [camel-quarkus] gus-maurizio opened a new issue #3394: using the latest quarkus camel 2.5.3.Final camel.main.durationMax* parameters seem not to be operating
gus-maurizio opened a new issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394
I need the camel quarkus routes to terminate after a certain amount of seconds or processing a number of messages.
This was defined by the camel-quarkus-main, that seems not supported any longer.
How do I achieve this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
jamesnetherton closed issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] gus-maurizio commented on issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
gus-maurizio commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-1015408510
Any progress or ETA on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
aldettinger commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-1015410004
@gus-maurizio Not really from my side. I can resume as soon as I have time. Unless someone else is willing to pick it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] gus-maurizio commented on issue #3394: using the latest quarkus camel 2.5.3.Final camel.main.durationMax* parameters seem not to be operating
Posted by GitBox <gi...@apache.org>.
gus-maurizio commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-996770726
Correction. MaxMessages and MaxIdleSeconds work, but durationMaxSeconds seems to be ignored.
camel.main.durationMaxIdleSeconds = 120
camel.main.durationMaxMessages = 300
camel.main.durationMaxSeconds = 30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] gus-maurizio commented on issue #3394: using the latest quarkus camel 2.5.3.Final camel.main.durationMax* parameters seem not to be operating
Posted by GitBox <gi...@apache.org>.
gus-maurizio commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-999571048
I was not able to download and compile this to check, and I was using the latest stable version, so please verify,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] gus-maurizio commented on issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
gus-maurizio commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-1004752263
Was working in 1.8.1.final
Sent from my iPad
> On Jan 4, 2022, at 3:49 AM, Alexandre Gallice ***@***.***> wrote:
>
>
> @gus-maurizio Reading #1441, could you please confirm that durationMaxSeconds was working in a previous camel-quarkus version ? which one please ? And then it stop working when you upgraded to 2.5.3.Final ?
>
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you were mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] gus-maurizio commented on issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
gus-maurizio commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-1029215540
Thanks to all the team! It is now working with the latest release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
aldettinger commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-1004624452
@gus-maurizio Reading #1441, could you please confirm that durationMaxSeconds was working in a previous camel-quarkus version ? which one please ? And then it stop working when you upgraded to 2.5.3.Final ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on issue #3394: using the latest quarkus camel 2.5.3.Final camel.main.durationMax* parameters seem not to be operating
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-999518505
Could you @gus-maurizio or anybody else please modify this integration test to reproduce the issue? https://github.com/apache/camel-quarkus/tree/main/integration-tests/main-command-mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-1004917018
Ah so you do not extend the camel-main class but do you own. Yeah then those methods needs to be protected so you can call them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
aldettinger commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-1004907832
This issue can be reproduced with camel-quarkus 2.6.0 while it's working with pure camel 3.14.0, so the issue relies in camel-quakus.
After investigations:
+ A CamelMainRuntime is assembled and [started](https://github.com/apache/camel-quarkus/blob/main/extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/main/CamelMainRuntime.java#L49)
+ oacq.main.CamelMain.runEngine() calls [waitUntilCompleted()](https://github.com/apache/camel-quarkus/blob/main/extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/main/CamelMain.java#L150)
+ `durationMaxSeconds` is equals to zero in [oac.main.MainSupport.waitUntilCompleted()](https://github.com/apache/camel/blob/main/core/camel-main/src/main/java/org/apache/camel/main/MainSupport.java#L301..L304) while **it should not**
It looks that `durationMaxSeconds` should be set in [internalBeforeStart()](https://github.com/apache/camel/blob/main/core/camel-main/src/main/java/org/apache/camel/main/MainSupport.java#L66..L72) which is [private](https://github.com/apache/camel/blob/main/core/camel-main/src/main/java/org/apache/camel/main/MainSupport.java#L108..L112).
From there I wonder whether `internalBeforeStart()` should be made protected ? Or maybe `oacq.main.CamelMain` should be changed ?
@ppalaga @davsclaus What do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on issue #3394: using the latest quarkus camel 2.5.3.Final camel.main.durationMax* parameters seem not to be operating
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-999699702
> I was not able to download and compile this to check, and I was using the latest stable version, so please verify,
Should make no difference. Let's see whether the CI fails on the modified test https://github.com/apache/camel-quarkus/runs/4609110536?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] gus-maurizio commented on issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
gus-maurizio commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-1004929280
Just to provide a bit of context, along with congratulations to this team for working and finding the root cause.
This functionality is important in the context of running camel quarkus AWS lambda functions that are limited to at most 15 minutes. We leverage this and establish two criteria for termination, maxMessages (which is the preferred) and a fail-safe of maxDuration (to about 13 or 14 minutes) to ensure the routes can properly end what is in flight before being terminated by the underlying engine.
Merci bien Alexandre!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-1017237001
It'd be nice to fix this for the 2.7.0 release. I can take a look into it.
Until we have a Camel version with the `protected` `internalBeforeStart()`, I guess we can work around it on our side by setting the relevant main config like `mainConfigurationProperties.setDurationMaxSeconds(someValue)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] gus-maurizio commented on issue #3394: using the latest quarkus camel 2.5.3.Final camel.main.durationMax* parameters seem not to be operating
Posted by GitBox <gi...@apache.org>.
gus-maurizio commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-999570574
Thanks Peter, I created a pull request: Update CamelRoute.java #3408
Modified the application properties (to stop JVM after 10 seconds) and the timer settings (to delay 20 seconds) to show the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] gus-maurizio commented on issue #3394: using the latest quarkus camel 2.5.3.Final camel.main.durationMax* parameters seem not to be operating
Posted by GitBox <gi...@apache.org>.
gus-maurizio commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-999738507
Let me know if you need anything else from me Peter. Thanks for your help.
G
> On Dec 22, 2021, at 11:18 AM, Peter Palaga ***@***.***> wrote:
>
>
> I was not able to download and compile this to check, and I was using the latest stable version, so please verify,
>
> Should make no difference. Let's see whether the CI fails on the modified test https://github.com/apache/camel-quarkus/runs/4609110536?check_suite_focus=true
>
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you were mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on issue #3394: camel.main.durationMaxSeconds is not honoured
Posted by GitBox <gi...@apache.org>.
aldettinger commented on issue #3394:
URL: https://github.com/apache/camel-quarkus/issues/3394#issuecomment-1017290488
Sure @jamesnetherton , you are welcome to move this ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org