[GitHub] [samza] b-slim opened a new pull request #1407: [SAMZA-2573] Ensure the top level order column feeding into the sql translation matches Schema

[GitBox <gi...@apache.org>]

b-slim opened a new pull request #1407:
URL: https://github.com/apache/samza/pull/1407


   **Issues:** Currently the order of Samza SQL schema and actual physical row coming from Samza is not guarantee to be correct aka the same. That is because the Schema injection layer is totally disconnected form the translation layer.
   **Changes:** This work add a map phase to ensure that the order is as expected between the Row Signature and the actual physical row.
   **Tests:** To test this I have shifted the order of `__key__` and run all the test to made sure it works.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] weiqingy commented on a change in pull request #1407: [SAMZA-2573] Ensure the top level order column feeding into the sql translation matches Schema

[GitBox <gi...@apache.org>]

weiqingy commented on a change in pull request #1407:
URL: https://github.com/apache/samza/pull/1407#discussion_r485869977



##########
File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java
##########
@@ -99,17 +99,6 @@ public SamzaSqlRelMessage convertToRelMessage(KV<Object, Object> samzaMessage) {
         new SamzaSqlRelMsgMetadata(0L, 0L));
   }
 
-  /**
-   * Create a SamzaSqlRelMessage for the specified key and Avro record using the schema from the Avro record.
-   *
-   */
-  public static SamzaSqlRelMessage convertToRelMessage(Object key, IndexedRecord record, Schema schema) {

Review comment:
       although convertToRelMessage is used in samza repo directly, it is invoked by others, e.g. BrooklinRelConverter and other xxxRelconverter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org