You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2015/10/03 16:40:44 UTC

[GitHub] storm pull request: [STORM-1038] Upgraded netty to 4.x

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/728#issuecomment-145253788
  
    @hsun-cnnxty, The changes look good to me.  Please upmerge to the latest code.  Then I would like to run some performance tests on it to see how it compares to the current code.  Please also look at shading.  In storm-core we are shading netty now, and I would like to be sure that it is still shaded correctly.
    
    If you have any questions on how to do this please let me know and I will be happy to help out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---