You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/12/22 20:19:00 UTC
[jira] [Work logged] (BEAM-13427) [Playground] Get and show log outputs for precompiled objects
[ https://issues.apache.org/jira/browse/BEAM-13427?focusedWorklogId=700235&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-700235 ]
ASF GitHub Bot logged work on BEAM-13427:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/21 20:18
Start Date: 22/Dec/21 20:18
Worklog Time Spent: 10m
Work Description: KonradJanica commented on a change in pull request #16183:
URL: https://github.com/apache/beam/pull/16183#discussion_r774150100
##########
File path: playground/frontend/lib/pages/playground/states/examples_state.dart
##########
@@ -54,11 +54,22 @@ class ExampleState with ChangeNotifier {
return source;
}
+ Future<String> getExampleLogs(String id, SDK sdk) async {
+ String source = await _exampleRepository.getExampleLogs(
+ GetExampleRequestWrapper(id, sdk),
+ );
+ return source;
Review comment:
Nit: return the await statement directly instead of saving it into a variable.
##########
File path: playground/frontend/lib/modules/editor/parsers/run_options_parser.dart
##########
@@ -16,7 +16,8 @@
* limitations under the License.
*/
-RegExp regExp = RegExp(r'\-\-([A-z0-9]*)\s*([A-z0-9]*)\s*');
+RegExp pipelineOptionsRegExp =
+ RegExp(r"""--([A-z0-9]*)\s+([A-z0-9\/\"\'\*\-\:\;\.]*)""");
Review comment:
nit: use single quotes instead for better readability => r'''--([A-z0-9]*)\s+([A-z0-9\/\"\'\*\-\:\;\.]*)'''
##########
File path: playground/frontend/lib/modules/examples/repositories/example_repository.dart
##########
@@ -47,4 +47,11 @@ class ExampleRepository {
final result = await _client.getExampleOutput(request);
return result.output;
}
+
+ Future<String> getExampleLogs(
+ GetExampleRequestWrapper request,
+ ) async {
+ final result = await _client.getExampleLogs(request);
Review comment:
nit: replace with `return await _client.getExampleLogs(request).output;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 700235)
Remaining Estimate: 0h
Time Spent: 10m
> [Playground] Get and show log outputs for precompiled objects
> -------------------------------------------------------------
>
> Key: BEAM-13427
> URL: https://issues.apache.org/jira/browse/BEAM-13427
> Project: Beam
> Issue Type: Sub-task
> Components: beam-playground
> Reporter: Aydar Farrakhov
> Assignee: Aydar Farrakhov
> Priority: P2
> Labels: beam-playground-frontend, beam-playground-sprint-5
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)