You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org> on 2010/05/02 11:09:55 UTC
[jira] Created: (MYFACES-2693) UIRepeat has to override visitTree()
UIRepeat has to override visitTree()
------------------------------------
Key: MYFACES-2693
URL: https://issues.apache.org/jira/browse/MYFACES-2693
Project: MyFaces Core
Issue Type: Task
Components: JSR-314
Affects Versions: 2.0.0
Reporter: Jakob Korherr
Assignee: Jakob Korherr
While working on the extended debug support, I noticed that ui:repeat only visits its children once whereas it should visit them once for every value in the DataModel (somehow like UIData.visitTree()). A black box test of mojarra confirmed my thoughts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (MYFACES-2693) UIRepeat has to
override visitTree() and invokeOnComponent()
Posted by "Mark Li (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863663#action_12863663 ]
Mark Li edited comment on MYFACES-2693 at 5/4/10 1:56 AM:
----------------------------------------------------------
its work!
////////
does this solve the following problem? or i should create an other issue.
<ui:repeat var="v" value="#{lxh:indexArray(2)}">
<h:form>
<lxhs:commandButton action="#{TestBean.action}"></lxhs:commandButton>
</h:form>
</ui:repeat>
action will not be fired because:
public class PartialVisitContext extends VisitContext
{
............
@Override
public VisitResult invokeVisitCallback(
UIComponent component,
VisitCallback callback)
{
String clientId = _getVisitId(component);
}
............
}
getVisitId(component) return null, because on html page id of h:form is j*:0:j*, but on serverside it is j*:j*.
was (Author: puddlor):
does this solve the following problem? or i should create an other issue.
<ui:repeat var="v" value="#{lxh:indexArray(2)}">
<h:form>
<lxhs:commandButton action="#{TestBean.action}"></lxhs:commandButton>
</h:form>
</ui:repeat>
action will not be fired because:
public class PartialVisitContext extends VisitContext
{
............
@Override
public VisitResult invokeVisitCallback(
UIComponent component,
VisitCallback callback)
{
String clientId = _getVisitId(component);
}
............
}
getVisitId(component) return null, because on html page id of h:form is j*:0:j*, but on serverside it is j*:j*.
> UIRepeat has to override visitTree() and invokeOnComponent()
> ------------------------------------------------------------
>
> Key: MYFACES-2693
> URL: https://issues.apache.org/jira/browse/MYFACES-2693
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Fix For: 2.0.1-SNAPSHOT
>
>
> While working on the extended debug support, I noticed that ui:repeat only visits its children once whereas it should visit them once for every value in the DataModel (somehow like UIData.visitTree()). A black box test of mojarra confirmed my thoughts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2693) UIRepeat has to override
visitTree() and invokeOnComponent()
Posted by "Mark Li (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863663#action_12863663 ]
Mark Li commented on MYFACES-2693:
----------------------------------
does this solve the following problem? or i should create an other issue.
<ui:repeat var="v" value="#{lxh:indexArray(2)}">
<h:form>
<lxhs:commandButton action="#{TestBean.action}"></lxhs:commandButton>
</h:form>
</ui:repeat>
action will not be fired because:
public class PartialVisitContext extends VisitContext
{
............
@Override
public VisitResult invokeVisitCallback(
UIComponent component,
VisitCallback callback)
{
String clientId = _getVisitId(component);
}
............
}
getVisitId(component) return null, because on html page id of h:form is j*:0:j*, but on serverside it is j*:j*.
> UIRepeat has to override visitTree() and invokeOnComponent()
> ------------------------------------------------------------
>
> Key: MYFACES-2693
> URL: https://issues.apache.org/jira/browse/MYFACES-2693
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Fix For: 2.0.1-SNAPSHOT
>
>
> While working on the extended debug support, I noticed that ui:repeat only visits its children once whereas it should visit them once for every value in the DataModel (somehow like UIData.visitTree()). A black box test of mojarra confirmed my thoughts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2693) UIRepeat has to override
visitTree() and invokeOnComponent()
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr resolved MYFACES-2693.
------------------------------------
Fix Version/s: 2.0.1-SNAPSHOT
Resolution: Fixed
> UIRepeat has to override visitTree() and invokeOnComponent()
> ------------------------------------------------------------
>
> Key: MYFACES-2693
> URL: https://issues.apache.org/jira/browse/MYFACES-2693
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Fix For: 2.0.1-SNAPSHOT
>
>
> While working on the extended debug support, I noticed that ui:repeat only visits its children once whereas it should visit them once for every value in the DataModel (somehow like UIData.visitTree()). A black box test of mojarra confirmed my thoughts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2693) UIRepeat has to override
visitTree() and invokeOnComponent()
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863798#action_12863798 ]
Jakob Korherr commented on MYFACES-2693:
----------------------------------------
Hi Mark,
Just to wrap up: Yes, this issue solves your described bug :)
> UIRepeat has to override visitTree() and invokeOnComponent()
> ------------------------------------------------------------
>
> Key: MYFACES-2693
> URL: https://issues.apache.org/jira/browse/MYFACES-2693
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Fix For: 2.0.1-SNAPSHOT
>
>
> While working on the extended debug support, I noticed that ui:repeat only visits its children once whereas it should visit them once for every value in the DataModel (somehow like UIData.visitTree()). A black box test of mojarra confirmed my thoughts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2693) UIRepeat has to override
visitTree()
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863185#action_12863185 ]
Leonardo Uribe commented on MYFACES-2693:
-----------------------------------------
Don't forget invokeOnComponent too!.
> UIRepeat has to override visitTree()
> ------------------------------------
>
> Key: MYFACES-2693
> URL: https://issues.apache.org/jira/browse/MYFACES-2693
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
>
> While working on the extended debug support, I noticed that ui:repeat only visits its children once whereas it should visit them once for every value in the DataModel (somehow like UIData.visitTree()). A black box test of mojarra confirmed my thoughts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.