[GitHub] [arrow] pitrou commented on a change in pull request #7395: ARROW-9089: [Python] A PyFileSystem handler for fsspec-based filesystems

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#discussion_r438120986



##########
File path: python/pyarrow/tests/test_fs.py
##########
@@ -511,7 +545,8 @@ def test_get_file_info(fs, pathfn):
     assert 'aaa' in repr(aaa_info)
     assert aaa_info.extension == ''
     assert 'FileType.Directory' in repr(aaa_info)
-    assert aaa_info.size is None
+    # TODO fsspec gives a size for directories

Review comment:
       What does the size measure then?

##########
File path: python/pyarrow/tests/test_fs.py
##########
@@ -324,6 +350,14 @@ def hdfs(request, hdfs_connection):
         pytest.lazy_fixture('py_localfs'),
         id='PyFileSystem(ProxyHandler(LocalFileSystem()))'
     ),
+    pytest.param(
+        pytest.lazy_fixture('py_fsspec_localfs'),
+        id='PyFileSystem(FSSpecHandler(fsspec.LocalFileSystem()))'
+    ),
+    # pytest.param(
+    #     pytest.lazy_fixture('py_fsspec_memoryfs'),
+    #     id='PyFileSystem(FSSpecHandler(fsspec.filesystem("memory")))'

Review comment:
       Is there a reason this is disabled?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org