You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/09/22 02:25:57 UTC

[GitHub] [rocketmq] francisoliverlee edited a comment on pull request #3357: RIP-7 Multiple Directories Storage Support

francisoliverlee edited a comment on pull request #3357:
URL: https://github.com/apache/rocketmq/pull/3357#issuecomment-924529808


   > > > DiskCheckScheduledThread1
   > > 
   > > 
   > > @francisoliverlee Thank you for the notice.
   > > Error in `DiskCheckScheduledThread1` is due to storePathCommitLog usage in "DefaultMessageStore.CleanCommitLogService#isSpaceFull". I fixed it and added test in last commit.
   > > Sorry for missing that. I have checked all the usage of `storePathCommitLog`.
   > 
   > It seems this error still exists ，and maybe you discarded this method _org.apache.rocketmq.common.UtilAll#getDiskPartitionSpaceUsedPercent_, or should we check the existence of a directory at the start of the broker?
   
   error stills. 
   ![image](https://user-images.githubusercontent.com/5908412/134273780-29068ec0-9537-425b-91c8-009f7db8093f.png)
   
   when doing getDiskPartitionSpaceUsedPercent(),  how about a WARNING for NO consume queue dir ?
   @Jason918 @duhenglucky 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org