You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/04/11 07:18:45 UTC
[GitHub] [camel-k] gansheer commented on a diff in pull request #4239: fix(controller): camelcatalog default timeout
gansheer commented on code in PR #4239:
URL: https://github.com/apache/camel-k/pull/4239#discussion_r1162396389
##########
pkg/client/camel/applyconfiguration/camel/v1/integrationplatformbuildspec.go:
##########
@@ -27,15 +27,16 @@ import (
// IntegrationPlatformBuildSpecApplyConfiguration represents an declarative configuration of the IntegrationPlatformBuildSpec type for use
// with apply.
type IntegrationPlatformBuildSpecApplyConfiguration struct {
- BuildStrategy *v1.BuildStrategy `json:"buildStrategy,omitempty"`
- PublishStrategy *v1.IntegrationPlatformBuildPublishStrategy `json:"publishStrategy,omitempty"`
- RuntimeVersion *string `json:"runtimeVersion,omitempty"`
- RuntimeProvider *v1.RuntimeProvider `json:"runtimeProvider,omitempty"`
- BaseImage *string `json:"baseImage,omitempty"`
- Registry *RegistrySpecApplyConfiguration `json:"registry,omitempty"`
- Timeout *metav1.Duration `json:"timeout,omitempty"`
- Maven *MavenSpecApplyConfiguration `json:"maven,omitempty"`
- PublishStrategyOptions map[string]string `json:"PublishStrategyOptions,omitempty"`
+ BuildStrategy *v1.BuildStrategy `json:"buildStrategy,omitempty"`
+ PublishStrategy *v1.IntegrationPlatformBuildPublishStrategy `json:"publishStrategy,omitempty"`
+ RuntimeVersion *string `json:"runtimeVersion,omitempty"`
+ RuntimeProvider *v1.RuntimeProvider `json:"runtimeProvider,omitempty"`
+ BaseImage *string `json:"baseImage,omitempty"`
+ Registry *RegistrySpecApplyConfiguration `json:"registry,omitempty"`
+ BuildCatalogToolTimeout *int `json:"buildCatalogToolTimeout,omitempty"`
Review Comment:
Just curious : why not use the same type as the `Timeout` parameter ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org