You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/26 04:24:50 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26259: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.

dongjoon-hyun commented on a change in pull request #26259: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
URL: https://github.com/apache/spark/pull/26259#discussion_r339285577
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
 ##########
 @@ -298,6 +303,7 @@ private[ui] class ExecutionPagedTable(
 
     val headerRow: Seq[Node] = {
       executionHeadersAndCssClasses.map { case (header, sortable) =>
+        val headerTooltip = headerNameWithTooltips.getOrElse(header,"")
 
 Review comment:
   Hi, @07ARB . Could you run `dev/scalastyle` and fix this line?
   As you see, `GitHub Action` failed due to this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org