[jira] [Closed] (OFBIZ-7122) Showing Invoice address from PartyContactMech

["Arun Patidar (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-7122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun Patidar closed OFBIZ-7122.
-------------------------------
       Resolution: Fixed
    Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1749888

Thanks [~rahul.kushwah] for your contribution.

> Showing Invoice address from PartyContactMech
> ---------------------------------------------
>
>                 Key: OFBIZ-7122
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7122
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Arun Patidar
>            Assignee: Arun Patidar
>             Fix For: Upcoming Branch
>
>         Attachments: InvoiceWorker.patch
>
>
> In getInvoiceAddressByType() method of InvoiceWorker, it is fetching address from PartyContactWithPurpose in case of empty InvoiceContactMech.
> This method calls from two methods getBillToAddress() and getSendFromAddress() of same class.
> Here, my concerns are:
> - There is no way to check that returned address is invoice associated address or party address. It is misleading.
> - There is no control of user to get the address linked to invoice only.
> My proposals is:
> 1). System should return party address only if user really demand for it. We can override method and pass additional parameter for achieving this. Systems default behavior should same as current.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)