You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2026/07/05 13:53:11 UTC

(commons-fileupload) branch master updated: Flip null test

This is an automated email from the ASF dual-hosted git repository.

garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git


The following commit(s) were added to refs/heads/master by this push:
     new 2cef37d6 Flip null test
2cef37d6 is described below

commit 2cef37d684113676fed9b5c11abb48346f28d162
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jul 5 09:53:06 2026 -0400

    Flip null test
---
 .../java/org/apache/commons/fileupload2/core/FileItemHeadersImpl.java | 4 ++--
 .../apache/commons/fileupload2/core/FileItemInputIteratorImpl.java    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/FileItemHeadersImpl.java b/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/FileItemHeadersImpl.java
index f124da92..64007121 100644
--- a/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/FileItemHeadersImpl.java
+++ b/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/FileItemHeadersImpl.java
@@ -51,7 +51,7 @@ class FileItemHeadersImpl implements FileItemHeaders {
     @Override
     public String getHeader(final String name) {
         final var headerValueList = getList(name);
-        if (null == headerValueList) {
+        if (headerValueList == null) {
             return null;
         }
         return headerValueList.get(0);
@@ -71,7 +71,7 @@ class FileItemHeadersImpl implements FileItemHeaders {
     @Override
     public Iterator<String> getHeaders(final String name) {
         var headerValueList = getList(name);
-        if (null == headerValueList) {
+        if (headerValueList == null) {
             headerValueList = Collections.emptyList();
         }
         return headerValueList.iterator();
diff --git a/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/FileItemInputIteratorImpl.java b/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/FileItemInputIteratorImpl.java
index b936e82a..2c38efc4 100644
--- a/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/FileItemInputIteratorImpl.java
+++ b/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/FileItemInputIteratorImpl.java
@@ -248,7 +248,7 @@ class FileItemInputIteratorImpl implements FileItemInputIterator {
 
     protected void init(final AbstractFileUpload<?, ?, ?> fileUploadBase, final RequestContext initContext) throws FileUploadException, IOException {
         final var contentType = requestContext.getContentType();
-        if (null == contentType || !contentType.toLowerCase(Locale.ROOT).startsWith(AbstractFileUpload.MULTIPART)) {
+        if (contentType == null || !contentType.toLowerCase(Locale.ROOT).startsWith(AbstractFileUpload.MULTIPART)) {
             throw new FileUploadContentTypeException(String.format("the request doesn't contain a %s or %s stream, content type header is %s",
                     AbstractFileUpload.MULTIPART_FORM_DATA, AbstractFileUpload.MULTIPART_MIXED, contentType), contentType);
         }