[jira] [Resolved] (SPARK-38836) Increase the performance of ExpressionSet

["Wenchen Fan (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-38836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wenchen Fan resolved SPARK-38836.
---------------------------------
    Fix Version/s: 3.4.0
       Resolution: Fixed

Issue resolved by pull request 36121
[https://github.com/apache/spark/pull/36121]

> Increase the performance of ExpressionSet
> -----------------------------------------
>
>                 Key: SPARK-38836
>                 URL: https://issues.apache.org/jira/browse/SPARK-38836
>             Project: Spark
>          Issue Type: Improvement
>          Components: Optimizer
>    Affects Versions: 3.2.1
>            Reporter: Min Yang
>            Priority: Minor
>             Fix For: 3.4.0
>
>
> Since the constructor of `ExpressionSet` is protected, callers can only modify the state of an `ExpressionSet` by calling `add` and `remove`, so it maintains the invariants of:
>  # Every expr `e` in `baseSet` satisfies `e.deterministic && e.canonicalized == e`
>  # Every deterministic expr `e` in `originals` satisfies that `e.canonicalized` is already accessed.
> The current implementation ignores the invariant and unnecessarily calls `.canonicalized` in lots of places which can cause performance issues as `canonicalized` is a pretty expensive operation.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org