You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/31 14:09:53 UTC
[GitHub] [bookkeeper] Shoothzj opened a new pull request #3166: [build] Complement missing maven plugin version
Shoothzj opened a new pull request #3166:
URL: https://github.com/apache/bookkeeper/pull/3166
### Changes
Complement missing maven plugin version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3166: [build] Complement missing maven plugin version
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #3166:
URL: https://github.com/apache/bookkeeper/pull/3166#issuecomment-1085359742
@nicoloboschi please take a look agian, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #3166: [build] Complement missing maven plugin version
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #3166:
URL: https://github.com/apache/bookkeeper/pull/3166#discussion_r839742710
##########
File path: bookkeeper-server/pom.xml
##########
@@ -305,7 +305,7 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
- <version>1.6.0</version>
+ <version>${exec-maven-plugin.version}</version>
Review comment:
I mean the whole plugin configuration
Take the checkstyle conf as example:
https://github.com/apache/bookkeeper/blob/6fa5694d79918b5aed606376fcd5a7cc5ef34627/pom.xml#L822-L827
then you don't need to specify the version in submodules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3166: [build] Complement missing maven plugin version
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #3166:
URL: https://github.com/apache/bookkeeper/pull/3166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on a change in pull request #3166: [build] Complement missing maven plugin version
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on a change in pull request #3166:
URL: https://github.com/apache/bookkeeper/pull/3166#discussion_r839715758
##########
File path: bookkeeper-server/pom.xml
##########
@@ -305,7 +305,7 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
- <version>1.6.0</version>
+ <version>${exec-maven-plugin.version}</version>
Review comment:
@nicoloboschi it's already in the root POM? did I miss something?
##########
File path: bookkeeper-server/pom.xml
##########
@@ -305,7 +305,7 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
- <version>1.6.0</version>
+ <version>${exec-maven-plugin.version}</version>
Review comment:
@nicoloboschi it's already in the root POM. did I miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #3166: [build] Complement missing maven plugin version
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #3166:
URL: https://github.com/apache/bookkeeper/pull/3166#discussion_r839663891
##########
File path: bookkeeper-server/pom.xml
##########
@@ -305,7 +305,7 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
- <version>1.6.0</version>
+ <version>${exec-maven-plugin.version}</version>
Review comment:
it's better to add the version in the root POM using `pluginManagement`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3166: [build] Complement missing maven plugin version
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #3166:
URL: https://github.com/apache/bookkeeper/pull/3166#issuecomment-1084714945
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org