Re: [PR] [CALCITE-4860] In Elasticsearch adapter, support NULLS FIRST and NULLS LAST query [calcite]

["ILuffZhe (via GitHub)" <gi...@apache.org>]

ILuffZhe commented on code in PR #2657:
URL: https://github.com/apache/calcite/pull/2657#discussion_r1886960481


##########
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/AggregationAndSortTest.java:
##########
@@ -412,16 +412,62 @@ private static Connection createConnection() throws SQLException {
    */
   @Test void testGroupTextField() {
     CalciteAssert.that()
-        .with(AggregationTest::createConnection)
+        .with(AggregationAndSortTest::createConnection)
         .query("select cat6, count(1) as CNT from view group by cat6")
         .returnsUnordered("cat6=null; CNT=2",
             "cat6=text1; CNT=1");
 
     CalciteAssert.that()
-        .with(AggregationTest::createConnection)
+        .with(AggregationAndSortTest::createConnection)
         .query("select cat1, cat6 from view group by cat1, cat6")
         .returnsUnordered("cat1=a; cat6=null",
             "cat1=b; cat6=null",
             "cat1=null; cat6=text1");
   }
+
+  /** Test case for
+   * <a href="https://issues.apache.org/jira/browse/CALCITE-4860">[CALCITE-4860]
+   * In Elasticsearch adapter, support NULLS FIRST and NULLS LAST query</a>.
+   */
+  @Test void testNullsSort() {
+    CalciteAssert.that()

Review Comment:
   I don't put this test to ElasticSearchAdapterTest is because we need some null values, which may cause many unnecessary changes since we need to modify the zips-mini.json.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org