You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "lovasoa (via GitHub)" <gi...@apache.org> on 2025/02/21 17:21:40 UTC
[PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
lovasoa opened a new pull request, #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678881467
Ok, ast-grep is [a bit of a pita to use with rust](https://github.com/ast-grep/ast-grep/issues/853), but I managed to get it to do most of the work with the following rule:
```yaml
id: x
language: rust
rule:
any:
- kind: token_tree
pattern: $ARG
follows:
kind: identifier
pattern: Value
follows:
kind: identifier
pattern: Expr
stopBy: end
fix: ($ARG.with_empty_span())
```
the tests pass now !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1969034324
##########
tests/sqlparser_bigquery.rs:
##########
@@ -29,19 +29,19 @@ use test_utils::*;
#[test]
fn parse_literal_string() {
let sql = concat!(
- "SELECT ",
- "'single', ",
- r#""double", "#,
- "'''triple-single''', ",
- r#""""triple-double""", "#,
- r#"'single\'escaped', "#,
- r#"'''triple-single\'escaped''', "#,
- r#"'''triple-single'unescaped''', "#,
- r#""double\"escaped", "#,
- r#""""triple-double\"escaped""", "#,
- r#""""triple-double"unescaped""", "#,
- r#""""triple-double'unescaped""", "#,
- r#"'''triple-single"unescaped'''"#,
+ "SELECT ", // line 1, column 1
+ "'single', ", // line 1, column 7
+ r#""double", "#, // line 1, column 14
+ "'''triple-single''', ", // line 1, column 22
+ r#""""triple-double""", "#, // line 1, column 33
+ r#"'single\'escaped', "#, // line 1, column 43
+ r#"'''triple-single\'escaped''', "#, // line 1, column 55
+ r#"'''triple-single'unescaped''', "#, // line 1, column 68
+ r#""double\"escaped", "#, // line 1, column 83
+ r#""""triple-double\"escaped""", "#, // line 1, column 92
+ r#""""triple-double"unescaped""", "#, // line 1, column 105
+ r#""""triple-double'unescaped""", "#, // line 1, column 118
+ r#"'''triple-single"unescaped'''"#, // line 1, column 131
Review Comment:
do the added comments here need cleanup or do they serve a purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2683188897
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2675136484
feel free to edit the code directly without asking me first :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on code in PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967171526
##########
tests/sqlparser_bigquery.rs:
##########
@@ -50,112 +50,146 @@ fn parse_literal_string() {
let select = dialect.verified_only_select(sql);
assert_eq!(12, select.projection.len());
assert_eq!(
- &Expr::Value(Value::SingleQuotedString("single".into())),
+ &Expr::Value(
+ Value::SingleQuotedString("single".into())
+ .with_span(Span::new(Location::new(1, 7), Location::new(1, 12)))
+ ),
Review Comment:
Yes, that would tremendously reduce the amount of work to do in the tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1968440688
##########
src/ast/mod.rs:
##########
@@ -8789,9 +8796,9 @@ mod tests {
#[test]
fn test_interval_display() {
let interval = Expr::Interval(Interval {
- value: Box::new(Expr::Value(Value::SingleQuotedString(String::from(
- "123:45.67",
- )))),
+ value: Box::new(Expr::Value(
Review Comment:
minor stuff we could use the `Expr::value` here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio merged PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "eliaperantoni (via GitHub)" <gi...@apache.org>.
eliaperantoni commented on code in PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967336588
##########
src/ast/value.rs:
##########
@@ -26,10 +26,25 @@ use bigdecimal::BigDecimal;
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
-use crate::ast::Ident;
+use crate::{ast::Ident, tokenizer::Span};
#[cfg(feature = "visitor")]
use sqlparser_derive::{Visit, VisitMut};
+/// Primitive SQL values such as number and string
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
+pub struct ValueWrapper {
+ pub value: Value,
+ pub span: Span,
+}
Review Comment:
Based on previous feedback I got from @alamb, I think we should manually implement those traits on `ValueWrapper`, so that `span` is ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on code in PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967358401
##########
src/ast/value.rs:
##########
@@ -26,10 +26,25 @@ use bigdecimal::BigDecimal;
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
-use crate::ast::Ident;
+use crate::{ast::Ident, tokenizer::Span};
#[cfg(feature = "visitor")]
use sqlparser_derive::{Visit, VisitMut};
+/// Primitive SQL values such as number and string
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
+pub struct ValueWrapper {
+ pub value: Value,
+ pub span: Span,
+}
Review Comment:
Ok, I made the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678717651
@lovasoa here is a proposed contribution:
- https://github.com/lovasoa/sqlparser-rs/pull/1
If you like that, I think we can apply the same thing to the other tests fairly easily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678615822
> If someone wants to volunteer help...
I will post a note in DataFUsion slack and see if I can find anyone to help
In terms of logitistics, I suggest people:
1. Check out your branch
2. Fix one or two of the tests
3. Make a PR targeting your branch.
I will do an example of this for one or two in a moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1972433284
##########
src/ast/mod.rs:
##########
@@ -8789,9 +8796,9 @@ mod tests {
#[test]
fn test_interval_display() {
let interval = Expr::Interval(Interval {
- value: Box::new(Expr::Value(Value::SingleQuotedString(String::from(
- "123:45.67",
- )))),
+ value: Box::new(Expr::Value(
Review Comment:
I saw it in my editor and couldn't exist:
- https://github.com/apache/datafusion-sqlparser-rs/pull/1749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2679021258
It appears there are a few failed tests:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on code in PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967169666
##########
src/ast/value.rs:
##########
@@ -26,10 +26,25 @@ use bigdecimal::BigDecimal;
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
-use crate::ast::Ident;
+use crate::{ast::Ident, tokenizer::Span};
#[cfg(feature = "visitor")]
use sqlparser_derive::{Visit, VisitMut};
+/// Primitive SQL values such as number and string
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
+pub struct ValueWrapper {
+ pub value: Value,
+ pub span: Span,
+}
Review Comment:
I don't know. What do you think is best?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678918594
Looking quite nice!
Any chance you can pull the doc strings from https://github.com/lovasoa/sqlparser-rs/pull/1/commits/4d101b0f4af2b9381bea63ca6d58f61926e6b10f as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2676821051
FYI @eliaperantoni -- any chance you are willing to help our with this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678995461
> Any chance you can pull the doc strings from https://github.com/lovasoa/sqlparser-rs/commit/4d101b0f4af2b9381bea63ca6d58f61926e6b10f as well?
I did. I think this is ready for merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2679030792
> It appears there are a few failed tests
:grimacing: I had forgotten to run `cargo test --all-features`. It's fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2679141697
It would be nice if we could get this merged before other pending PRs, because it touches almost all the tests, and is guaranteed to generate big conflicts as we change them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "eliaperantoni (via GitHub)" <gi...@apache.org>.
eliaperantoni commented on code in PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1967128017
##########
src/ast/value.rs:
##########
@@ -26,10 +26,25 @@ use bigdecimal::BigDecimal;
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
-use crate::ast::Ident;
+use crate::{ast::Ident, tokenizer::Span};
#[cfg(feature = "visitor")]
use sqlparser_derive::{Visit, VisitMut};
+/// Primitive SQL values such as number and string
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
+pub struct ValueWrapper {
+ pub value: Value,
+ pub span: Span,
+}
Review Comment:
Do we want `Span` to influence `ValueWrapper`'s implementations of `PartialEq`, `PartialOrd`, and `Hash`?
##########
tests/sqlparser_bigquery.rs:
##########
@@ -50,112 +50,146 @@ fn parse_literal_string() {
let select = dialect.verified_only_select(sql);
assert_eq!(12, select.projection.len());
assert_eq!(
- &Expr::Value(Value::SingleQuotedString("single".into())),
+ &Expr::Value(
+ Value::SingleQuotedString("single".into())
+ .with_span(Span::new(Location::new(1, 7), Location::new(1, 12)))
+ ),
Review Comment:
Perhaps there's an automated way to do this, instead of manually writing locations?
I had to do something similar in one of my DataFusion PRs:
https://github.com/eliaperantoni/datafusion/blob/7265bd2d4d6fd86d34ce69672739b10aa4995b8c/datafusion/sql/tests/cases/diagnostic.rs#L132-L140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on code in PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#discussion_r1968471231
##########
src/ast/mod.rs:
##########
@@ -8789,9 +8796,9 @@ mod tests {
#[test]
fn test_interval_display() {
let interval = Expr::Interval(Interval {
- value: Box::new(Expr::Value(Value::SingleQuotedString(String::from(
- "123:45.67",
- )))),
+ value: Box::new(Expr::Value(
Review Comment:
Yes! But I don't have the strength to fight ast-grep again 🙂↔️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [WIP] Store spans for Value expressions [datafusion-sqlparser-rs]
Posted by "lovasoa (via GitHub)" <gi...@apache.org>.
lovasoa commented on PR #1738:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1738#issuecomment-2678028420
If someone wants to volunteer help...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org