You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Devang Mehta (JIRA)" <ax...@ws.apache.org> on 2004/12/25 07:41:03 UTC
[jira] Created: (AXIS-1738) Object Comparison in SOAPHeader.getHeadersByActors(...) seems to be incorrect.
Object Comparison in SOAPHeader.getHeadersByActors(...) seems to be incorrect.
-------------------------------------------------------------------------------
Key: AXIS-1738
URL: http://nagoya.apache.org/jira/browse/AXIS-1738
Project: Axis
Type: Bug
Components: SAAJ
Versions: 1.2
Environment: Windows 2000 Professional. JDK 1.4.2_03 mixed mode. JUnit 3.8
Reporter: Devang Mehta
Hi,
While going through the Code of SOAPHeader.java file for the method getHeadersByActor(ArrayList actors) I observed that
the compliance check for SOAP1.2 is done using the == operator. When i executed the attached JUnit for the same, the JUnit TC failed.
On analyzing the same i observed that the failure was because of the == comparison of objects. I modified the code to replace the == comparison with
instanceof comparison the TC has passed.
I am attaching the HTML diff (using CSDiff utility) of the SOAPHeader File and also the JUnit TC
The base code of SOAPHeader file is the one present in Axis 1.2RC2 code.
P.S. I have found similar such occurences in the RC2 code in other classes too. If I am right then you might need to update even those files. I will be able to list the filenames and post it here or on the developers mailing list.
Regards,
Devang.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (AXIS-1738) Object Comparison in SOAPHeader.getHeadersByActors(...) seems to be incorrect.
Posted by "Devang Mehta (JIRA)" <ax...@ws.apache.org>.
[ http://nagoya.apache.org/jira/browse/AXIS-1738?page=history ]
Devang Mehta updated AXIS-1738:
-------------------------------
Attachment: SOAPHeader.html
SOAPHeaderTest.java
Support files for the Reported Bug.
(Visible to jira-users)
> Object Comparison in SOAPHeader.getHeadersByActors(...) seems to be incorrect.
> -------------------------------------------------------------------------------
>
> Key: AXIS-1738
> URL: http://nagoya.apache.org/jira/browse/AXIS-1738
> Project: Axis
> Type: Bug
> Components: SAAJ
> Versions: 1.2
> Environment: Windows 2000 Professional. JDK 1.4.2_03 mixed mode. JUnit 3.8
> Reporter: Devang Mehta
> Attachments: SOAPHeader.html, SOAPHeaderTest.java
>
> Hi,
> While going through the Code of SOAPHeader.java file for the method getHeadersByActor(ArrayList actors) I observed that
> the compliance check for SOAP1.2 is done using the == operator. When i executed the attached JUnit for the same, the JUnit TC failed.
>
> On analyzing the same i observed that the failure was because of the == comparison of objects. I modified the code to replace the == comparison with
> instanceof comparison the TC has passed.
>
> I am attaching the HTML diff (using CSDiff utility) of the SOAPHeader File and also the JUnit TC
>
> The base code of SOAPHeader file is the one present in Axis 1.2RC2 code.
>
> P.S. I have found similar such occurences in the RC2 code in other classes too. If I am right then you might need to update even those files. I will be able to list the filenames and post it here or on the developers mailing list.
> Regards,
> Devang.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira