[GitHub] [superset] dpgaspar commented on pull request #16674: fix: report with timeout chart

[GitBox <gi...@apache.org>]

dpgaspar commented on pull request #16674:
URL: https://github.com/apache/superset/pull/16674#issuecomment-919036289


   > * i like the idea about invalidate cache for report.
   > * report cache and dashboard cache should be able to set separately.
   
   +1
   
   > * I am not sure _retry_ can solve this problem. Let say i have a slow query always taking ~100 seconds to run. During report time, webdriver triggers the query, after 60 seconds it got timeout exception, then the dashboard report will be hold for retry? And after webdriver triggered the 2nd try, it could not get the query results from 1st try at 100 seconds, right? So when is the best time to trigger next try?
   
   > * currently we have 60 second timeout, can we have extra config allow wait longer? As a report, in my opinion, the queries should be verified and optimized, so that each chart/query should no longer than a limit. 60 second seems a little tough, maybe 120 seconds is good enough (without retry)?
   
   you mean besides `SCREENSHOT_LOCATE_WAIT` and `SCREENSHOT_LOAD_WAIT`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org