You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/05/29 06:50:54 UTC
[GitHub] [airflow] uranusjr commented on a diff in pull request #31543: add error handling in case of 404 errors to protm script
uranusjr commented on code in PR #31543:
URL: https://github.com/apache/airflow/pull/31543#discussion_r1208978685
##########
dev/stats/get_important_pr_candidates.py:
##########
@@ -282,7 +287,10 @@ def score(self):
# Weight PRs with protm tags more heavily:
# If there is at least one protm tag, multiply the interaction score by the number of tags, up to 3.
interaction_score = self.interaction_score
- interaction_score *= min(self.protm_score + 1, 3)
+ try:
+ interaction_score *= min(self.protm_score + 1, 3)
+ except AttributeError:
Review Comment:
This can happen if the pickle is stale, but I think we should let it raise and resolve by re-building the pickle instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org