You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/13 11:24:35 UTC

[GitHub] [superset] villebro commented on pull request #12489: fix(timepicker): make pyparsing thread safe

villebro commented on pull request #12489:
URL: https://github.com/apache/superset/pull/12489#issuecomment-759385906


   > Looks like packrat cache comes with a lock for free: https://github.com/pyparsing/pyparsing/blob/f10fcf8c98ea07a63f8286288ce82f773e7e152e/pyparsing/core.py#L719
   > 
   > So I'm 90% sure this will fix the bug... (with the additional benefit of making things a little faster).
   
   I can confirm that this fixes the problem for me, too 👏  This looks like the perfect solution for this case. I think we can also re-enable the original memoization to get some additional perf improvement.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org