You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/02 06:02:35 UTC
[GitHub] [flink] KarmaGYZ opened a new pull request #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
KarmaGYZ opened a new pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Harden the Avro Confluent Schema Registry nightly end-to-end test.
## Brief change log
- Wrap the error when execute cleanup command in `retry_times_with_backoff_and_cleanup` function.
- Harden the way to loop in `retry_times_with_backoff_and_cleanup`
## Verifying this change
Trigger the Avro Confluent Schema Registry nightly end-to-end test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142953585 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
* 623ff819bc7612cc176ac51838f3815d2dd8a915 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142953585) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056)
* 3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142953585 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143332259 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
Hash:bae0233f1a15e5b88141d58e20344a605cca7079 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4168 TriggerType:PUSH TriggerID:bae0233f1a15e5b88141d58e20344a605cca7079
Hash:bae0233f1a15e5b88141d58e20344a605cca7079 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143401336 TriggerType:PUSH TriggerID:bae0233f1a15e5b88141d58e20344a605cca7079
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
* 623ff819bc7612cc176ac51838f3815d2dd8a915 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142953585) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056)
* 3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143332259) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144)
* bae0233f1a15e5b88141d58e20344a605cca7079 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143401336) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4168)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10742: [FLINK-15442] Harden
the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10742:
[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end
test
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363574005
##########
File path: flink-end-to-end-tests/test-scripts/kafka-common.sh
##########
@@ -36,7 +36,7 @@ function setup_kafka_dist {
mkdir -p $TEST_DATA_DIR
KAFKA_URL="https://archive.apache.org/dist/kafka/$KAFKA_VERSION/kafka_2.11-$KAFKA_VERSION.tgz"
echo "Downloading Kafka from $KAFKA_URL"
- curl "$KAFKA_URL" --retry 10 --retry-max-time 120 > $TEST_DATA_DIR/kafka.tgz
+ retry_times 5 0 "curl ${KAFKA_URL} --retry 10 --retry-max-time 120 --output ${TEST_DATA_DIR}/kafka.tgz"
Review comment:
Thanks for mention this. Yes, we could rely on the curl native mechanism. However, after reading the [curl manual](https://curl.haxx.se/docs/manpage.html). I found it's better to add the `--retry-delay` configure here to disable the exponential backoff mechanism. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
* 623ff819bc7612cc176ac51838f3815d2dd8a915 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10742:
[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end
test
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363351912
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -748,7 +748,7 @@ function retry_times_with_backoff_and_cleanup() {
local command="$3"
local cleanup_command="$4"
- for (( i = 0; i < ${retriesNumber}; i++ ))
+ for i in $(seq 1 ${retriesNumber})
Review comment:
Why is this better than the previous for loop version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10742:
[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end
test
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363354663
##########
File path: flink-end-to-end-tests/test-scripts/kafka-common.sh
##########
@@ -36,7 +36,7 @@ function setup_kafka_dist {
mkdir -p $TEST_DATA_DIR
KAFKA_URL="https://archive.apache.org/dist/kafka/$KAFKA_VERSION/kafka_2.11-$KAFKA_VERSION.tgz"
echo "Downloading Kafka from $KAFKA_URL"
- curl "$KAFKA_URL" --retry 10 --retry-max-time 120 > $TEST_DATA_DIR/kafka.tgz
+ retry_times 5 0 "curl ${KAFKA_URL} --retry 10 --retry-max-time 120 --output ${TEST_DATA_DIR}/kafka.tgz"
Review comment:
Weren't we already retrying the curl command by setting `--retry 10`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142953585 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143332259 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
* 623ff819bc7612cc176ac51838f3815d2dd8a915 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142953585) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056)
* 3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143332259) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10742:
[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end
test
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363747943
##########
File path: flink-end-to-end-tests/test-scripts/kafka-common.sh
##########
@@ -36,7 +36,7 @@ function setup_kafka_dist {
mkdir -p $TEST_DATA_DIR
KAFKA_URL="https://archive.apache.org/dist/kafka/$KAFKA_VERSION/kafka_2.11-$KAFKA_VERSION.tgz"
echo "Downloading Kafka from $KAFKA_URL"
- curl "$KAFKA_URL" --retry 10 --retry-max-time 120 > $TEST_DATA_DIR/kafka.tgz
+ curl ${KAFKA_URL} --retry 10 --retry-delay 2 --retry-max-time 120 --output ${TEST_DATA_DIR}/kafka.tgz
Review comment:
I think an exponential backoff strategy is usually something good. Hence, I would suggest to remove `--retry-delay`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142953585 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143332259 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
Hash:bae0233f1a15e5b88141d58e20344a605cca7079 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:bae0233f1a15e5b88141d58e20344a605cca7079
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
* 623ff819bc7612cc176ac51838f3815d2dd8a915 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142953585) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056)
* 3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143332259) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144)
* bae0233f1a15e5b88141d58e20344a605cca7079 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142953585 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
* 623ff819bc7612cc176ac51838f3815d2dd8a915 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142953585) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10742: [FLINK-15442] Harden
the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570125108
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b54283493f1ab8a44b5c4387012adf0524a54267 (Thu Jan 02 06:04:49 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142953585 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143332259 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
* 623ff819bc7612cc176ac51838f3815d2dd8a915 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142953585) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056)
* 3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143332259) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142953585 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143332259 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
Hash:bae0233f1a15e5b88141d58e20344a605cca7079 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4168 TriggerType:PUSH TriggerID:bae0233f1a15e5b88141d58e20344a605cca7079
Hash:bae0233f1a15e5b88141d58e20344a605cca7079 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143401336 TriggerType:PUSH TriggerID:bae0233f1a15e5b88141d58e20344a605cca7079
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
* 623ff819bc7612cc176ac51838f3815d2dd8a915 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142953585) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056)
* 3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143332259) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144)
* bae0233f1a15e5b88141d58e20344a605cca7079 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143401336) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4168)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142953585 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
* 623ff819bc7612cc176ac51838f3815d2dd8a915 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142953585) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10742:
[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end
test
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363745737
##########
File path: flink-end-to-end-tests/test-scripts/kafka-common.sh
##########
@@ -36,7 +36,7 @@ function setup_kafka_dist {
mkdir -p $TEST_DATA_DIR
KAFKA_URL="https://archive.apache.org/dist/kafka/$KAFKA_VERSION/kafka_2.11-$KAFKA_VERSION.tgz"
echo "Downloading Kafka from $KAFKA_URL"
- curl "$KAFKA_URL" --retry 10 --retry-max-time 120 > $TEST_DATA_DIR/kafka.tgz
+ retry_times 5 0 "curl ${KAFKA_URL} --retry 10 --retry-max-time 120 --output ${TEST_DATA_DIR}/kafka.tgz"
Review comment:
En exponential backoff is not necessarily bad. We've capped it to 120s which sounds fair to me. Hence, I don't think that we have to change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142953585 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:623ff819bc7612cc176ac51838f3815d2dd8a915 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056 TriggerType:PUSH TriggerID:623ff819bc7612cc176ac51838f3815d2dd8a915
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
Hash:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143332259 TriggerType:PUSH TriggerID:3318d116ea6a8bd675a9eafedc5f5fdca5e5d658
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
* 623ff819bc7612cc176ac51838f3815d2dd8a915 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142953585) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4056)
* 3318d116ea6a8bd675a9eafedc5f5fdca5e5d658 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143332259) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4144)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10742:
[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end
test
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363569355
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -748,7 +748,7 @@ function retry_times_with_backoff_and_cleanup() {
local command="$3"
local cleanup_command="$4"
- for (( i = 0; i < ${retriesNumber}; i++ ))
+ for i in $(seq 1 ${retriesNumber})
Review comment:
This block of loop will only executes 1 time in this scenario. I found that there is also a for loop in start_confluent_schema_registry function:
```
for i in {1..30}; do
if get_and_verify_schema_subjects_exist; then
echo "Schema registry is up."
return 0
fi
echo "Waiting for schema registry..."
sleep 1
done
```
The variable i is set to 30 after this function, which cause the loop end after only 1 execute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10742:
[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end
test
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363786018
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -748,7 +748,7 @@ function retry_times_with_backoff_and_cleanup() {
local command="$3"
local cleanup_command="$4"
- for (( i = 0; i < ${retriesNumber}; i++ ))
+ for i in $(seq 1 ${retriesNumber})
Review comment:
Ah this makes sense. Thanks a lot for your explanation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10742:
[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end
test
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363748006
##########
File path: flink-end-to-end-tests/test-scripts/kafka-common.sh
##########
@@ -50,7 +50,7 @@ function setup_confluent_dist {
mkdir -p $TEST_DATA_DIR
CONFLUENT_URL="http://packages.confluent.io/archive/$CONFLUENT_MAJOR_VERSION/confluent-oss-$CONFLUENT_VERSION-2.11.tar.gz"
echo "Downloading confluent from $CONFLUENT_URL"
- curl "$CONFLUENT_URL" > $TEST_DATA_DIR/confluent.tgz
+ curl ${CONFLUENT_URL} --retry 10 --retry-delay 2 --retry-max-time 120 --output ${TEST_DATA_DIR}/confluent.tgz
Review comment:
Same here with `retry-delay`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10742:
[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end
test
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363754200
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -748,7 +748,7 @@ function retry_times_with_backoff_and_cleanup() {
local command="$3"
local cleanup_command="$4"
- for (( i = 0; i < ${retriesNumber}; i++ ))
+ for i in $(seq 1 ${retriesNumber})
Review comment:
I think current scenario equals to the following script:
```
for (( i = 0; i < 10; i++ )) do
for i in {1..30}; do
echo $i
done
echo $i
done
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10742:
[FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end
test
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#discussion_r363747647
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -748,7 +748,7 @@ function retry_times_with_backoff_and_cleanup() {
local command="$3"
local cleanup_command="$4"
- for (( i = 0; i < ${retriesNumber}; i++ ))
+ for i in $(seq 1 ${retriesNumber})
Review comment:
I tried to reproduce the problem via
```
for i in {1..30}; do
echo $i
done
for (( i = 0; i < 10; i++ )) do
echo $i
done
```
When I execute this, then 1..30 and 0..9 will be printed. Hence, I'm not sure I really understand the problem you are describing. Could you provide me an example script to reproduce the problem with the old for loop?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10742: [FLINK-15442] Harden
the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-571412569
Thanks for the review @tillrohrmann . I've updated the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
KarmaGYZ edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-571412569
Thanks for the review @tillrohrmann . I've updated the PR.
Travis link https://travis-ci.org/KarmaGYZ/flink/builds/633584290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10742: [FLINK-15442]
Harden the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570129960
<!--
Meta data
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
Hash:b54283493f1ab8a44b5c4387012adf0524a54267 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142840214 TriggerType:PUSH TriggerID:b54283493f1ab8a44b5c4387012adf0524a54267
-->
## CI report:
* b54283493f1ab8a44b5c4387012adf0524a54267 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142840214) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4035)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10742: [FLINK-15442] Harden
the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-570444483
cc @tillrohrmann
Travis gives green light to the relevant test.
https://travis-ci.org/KarmaGYZ/flink/builds/632126284
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10742: [FLINK-15442] Harden
the Avro Confluent Schema Registry nightly end-to-end test
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10742: [FLINK-15442] Harden the Avro Confluent Schema Registry nightly end-to-end test
URL: https://github.com/apache/flink/pull/10742#issuecomment-571594400
Thanks for the review @tillrohrmann . I've removed the `retry-delay` and explained what happened in the loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services