You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/11/23 18:06:31 UTC
[GitHub] [httpcomponents-core] garydgregory opened a new pull request #231: 4.4.x use better map apis and more
garydgregory opened a new pull request #231:
URL: https://github.com/apache/httpcomponents-core/pull/231
Each commit in this PR comprise one kind of cleanup/change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #231: 4.4.x use better map apis and more
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #231:
URL: https://github.com/apache/httpcomponents-core/pull/231#issuecomment-732414509
Out of curiosity, did you make these changes manually, or using an automated tool?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on pull request #231: 4.4.x use better map apis and more
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #231:
URL: https://github.com/apache/httpcomponents-core/pull/231#issuecomment-732434002
> Out of curiosity, did you make these changes manually, or using an automated tool?
I started with Eclipse's clean ups and then made small adjustments by hand for clarity and added some comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #231: 4.4.x use better map apis and more
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #231:
URL: https://github.com/apache/httpcomponents-core/pull/231#issuecomment-732338738
what is the purpose of this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #231: 4.4.x use better map apis and more
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #231:
URL: https://github.com/apache/httpcomponents-core/pull/231#issuecomment-732414694
Are these present on 5.x?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on pull request #231: 4.4.x use better map apis and more
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #231:
URL: https://github.com/apache/httpcomponents-core/pull/231#issuecomment-732404171
> what is the purpose of this PR?
@michael-o
Please see updated description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory merged pull request #231: 4.4.x use better map apis and more
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #231:
URL: https://github.com/apache/httpcomponents-core/pull/231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on pull request #231: 4.4.x use better map apis and more
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #231:
URL: https://github.com/apache/httpcomponents-core/pull/231#issuecomment-732434312
> Are these present on 5.x?
Yes, please see my other PRs, there are 4 PRs in total.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on pull request #231: 4.4.x use better map apis and more
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #231:
URL: https://github.com/apache/httpcomponents-core/pull/231#issuecomment-732366499
Darn, I picked up to much history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on pull request #231: 4.4.x use better map apis and more
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #231:
URL: https://github.com/apache/httpcomponents-core/pull/231#issuecomment-732404895
> Darn, I picked up to much history.
Fixed my git.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org