You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2011/07/13 19:11:42 UTC

svn commit: r1146143 - /subversion/trunk/tools/dist/release.py

Author: hwright
Date: Wed Jul 13 17:11:42 2011
New Revision: 1146143

URL: http://svn.apache.org/viewvc?rev=1146143&view=rev
Log:
* tools/dist/release.py
  (roll_tarballs): One more special case for the 'nightly' Version.

Modified:
    subversion/trunk/tools/dist/release.py

Modified: subversion/trunk/tools/dist/release.py
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dist/release.py?rev=1146143&r1=1146142&r2=1146143&view=diff
==============================================================================
--- subversion/trunk/tools/dist/release.py (original)
+++ subversion/trunk/tools/dist/release.py Wed Jul 13 17:11:42 2011
@@ -384,7 +384,10 @@ def roll_tarballs(args):
     # For now, just delegate to dist.sh to create the actual artifacts
     extra_args = ''
     if args.version.is_prerelease():
-        extra_args = '-%s %d' % (args.version.pre, args.version.pre_num)
+        if args.version.pre == 'nightly':
+            extra_args = '-nightly'
+        else:
+            extra_args = '-%s %d' % (args.version.pre, args.version.pre_num)
     logging.info('Building UNIX tarballs')
     run_script(args.verbose, '%s/dist.sh -v %s -pr %s -r %d %s'
                      % (sys.path[0], args.version.base, branch, args.revnum,



Re: svn commit: r1146143 - /subversion/trunk/tools/dist/release.py

Posted by Hyrum K Wright <hy...@hyrumwright.org>.
On Wed, Jul 13, 2011 at 4:21 PM, Greg Stein <gs...@gmail.com> wrote:
> On Wed, Jul 13, 2011 at 13:11,  <hw...@apache.org> wrote:
>> Author: hwright
>> Date: Wed Jul 13 17:11:42 2011
>> New Revision: 1146143
>>
>> URL: http://svn.apache.org/viewvc?rev=1146143&view=rev
>> Log:
>> * tools/dist/release.py
>>  (roll_tarballs): One more special case for the 'nightly' Version.
>
> All of these special cases makes it seem that a rethink may be needed.
> That something in the approach is causing issues.
>
> (I don't have any specific feedback; just noting this in case you've
> been pushing forward without a pause :-) )

Yeah, I considered that.  I'm just trying to fix the nightly bot, but
I've no objection to revamping the above expectation.

-Hyrum

Re: svn commit: r1146143 - /subversion/trunk/tools/dist/release.py

Posted by Greg Stein <gs...@gmail.com>.
On Wed, Jul 13, 2011 at 13:11,  <hw...@apache.org> wrote:
> Author: hwright
> Date: Wed Jul 13 17:11:42 2011
> New Revision: 1146143
>
> URL: http://svn.apache.org/viewvc?rev=1146143&view=rev
> Log:
> * tools/dist/release.py
>  (roll_tarballs): One more special case for the 'nightly' Version.

All of these special cases makes it seem that a rethink may be needed.
That something in the approach is causing issues.

(I don't have any specific feedback; just noting this in case you've
been pushing forward without a pause :-) )

Cheers,
-g