You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2023/09/13 12:09:13 UTC

[GitHub] [yunikorn-core] FrankYang0529 commented on pull request #642: [YUNIKORN-1944] calculate headroom for wildcard cases

FrankYang0529 commented on PR #642:
URL: https://github.com/apache/yunikorn-core/pull/642#issuecomment-1717503891

   > Just for my understanding: Why https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/ugm/queue_tracker.go#L124-L135 block of code is not working correctly for max resources when it works for max applications?
   
   We don't handle the result from `IncreaseTrackedResource`, so it doesn't forbid new allocations.
   
   https://github.com/apache/yunikorn-core/blob/e19ffe6e33cac8d0283847dc898576cf83153b6b/pkg/scheduler/objects/application.go#L1664-L1666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org