You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/30 01:38:37 UTC
[GitHub] [iceberg] karuppayya opened a new pull request #2763: RemoveReachable files action should throw exception when GC enabled
karuppayya opened a new pull request #2763:
URL: https://github.com/apache/iceberg/pull/2763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2763: RemoveReachable files action should throw exception when GC enabled
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2763:
URL: https://github.com/apache/iceberg/pull/2763#issuecomment-871037581
Thanks, @karuppayya!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2763: RemoveReachable files action should throw exception when GC enabled
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #2763:
URL: https://github.com/apache/iceberg/pull/2763#discussion_r661075485
##########
File path: spark/src/main/java/org/apache/iceberg/spark/actions/BaseRemoveReachableFilesSparkAction.java
##########
@@ -80,6 +84,10 @@ public void accept(String file) {
public BaseRemoveReachableFilesSparkAction(SparkSession spark, String metadataLocation) {
super(spark);
this.metadataLocation = metadataLocation;
+ TableMetadata metadata = TableMetadataParser.read(io, metadataLocation);
Review comment:
Question: since we are reading the version file here, can we already cache `TableMetadata` to avoid reading it twice? Seems like we can replace `metadataLocation` with `metadata` and then use `metadataFileLocation()` if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2763: RemoveReachable files action should throw exception when GC enabled
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2763:
URL: https://github.com/apache/iceberg/pull/2763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2763: RemoveReachable files action should throw exception when GC enabled
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2763:
URL: https://github.com/apache/iceberg/pull/2763#issuecomment-872629093
Thanks @karuppayya!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] karuppayya commented on a change in pull request #2763: RemoveReachable files action should throw exception when GC enabled
Posted by GitBox <gi...@apache.org>.
karuppayya commented on a change in pull request #2763:
URL: https://github.com/apache/iceberg/pull/2763#discussion_r661858341
##########
File path: spark/src/main/java/org/apache/iceberg/spark/actions/BaseRemoveReachableFilesSparkAction.java
##########
@@ -80,6 +84,10 @@ public void accept(String file) {
public BaseRemoveReachableFilesSparkAction(SparkSession spark, String metadataLocation) {
super(spark);
this.metadataLocation = metadataLocation;
+ TableMetadata metadata = TableMetadataParser.read(io, metadataLocation);
Review comment:
I have cleaned up the code to remove `metadataLocation `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] karuppayya commented on pull request #2763: RemoveReachable files action should throw exception when GC enabled
Posted by GitBox <gi...@apache.org>.
karuppayya commented on pull request #2763:
URL: https://github.com/apache/iceberg/pull/2763#issuecomment-871032603
@aokolnychyi @RussellSpitzer @flyrain @kbendick Can you please help review this change, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org