You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by "Darrel Schneider (JIRA)" <ji...@apache.org> on 2017/05/02 18:16:04 UTC

[jira] [Created] (GEODE-2861) remove deadcode in GemFireCacheImpl and DiskStoreImpl for DiskStoreTaskPool

Darrel Schneider created GEODE-2861:
---------------------------------------

             Summary: remove deadcode in GemFireCacheImpl and DiskStoreImpl for DiskStoreTaskPool
                 Key: GEODE-2861
                 URL: https://issues.apache.org/jira/browse/GEODE-2861
             Project: Geode
          Issue Type: Improvement
          Components: persistence
            Reporter: Darrel Schneider


Both GemFireCacheImpl and DiskStoreImpl have deadcode related to shutting down the DiskStoreTaskPool.

On DiskStoreImpl see these methods:
  stopDiskStoreTaskPool
  shutdownPool
On GemFireCacheImpl the field diskStoreTaskPool is always null.

Note that a bug exists in this deadcode that causes it to not call taskCancelled as it iterates over a list of runnables. Since this code is dead it is currently doing no harm but if the code is not removed then make sure and fix this loop.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)