[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #3559: Snapshots that have timed out have been left on the secondary storage

[GitBox <gi...@apache.org>]

Spaceman1984 edited a comment on issue #3559:
URL: https://github.com/apache/cloudstack/issues/3559#issuecomment-712639640


   Creating a snapshot is an asynchronous process, 
   
   The expected result is that the files should be cleaned when the process times out. I'm not sure if this is the safest solution.
   
   At the point that the timeout occurs, Cloudstack doesn't make any assumptions that the process will eventually complete. It simply cleans up the DB. A timeout is there to prevent waiting for a process forever. 
   
   I think the question here should be, why is the process timing out? Wouldn't it make sense to just raise the timeout value then?
   
   I tested with a snapshot of a VM built using the built-in template and the process didn't time out - So this would seem like some kind of edge case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org