[GitHub] [pulsar] sijie commented on a change in pull request #10428: [Issue #10427] Add AvroSchema UUID support fix

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #10428:
URL: https://github.com/apache/pulsar/pull/10428#discussion_r625306171



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/util/SchemaUtil.java
##########
@@ -88,8 +90,10 @@ public static Schema extractAvroSchema(SchemaDefinition schemaDefinition, Class
         try {
             return parseAvroSchema(pojo.getDeclaredField("SCHEMA$").get(null).toString());
         } catch (NoSuchFieldException | IllegalAccessException | IllegalArgumentException ignored) {
-            return schemaDefinition.getAlwaysAllowNull() ? ReflectData.AllowNull.get().getSchema(pojo)
-                    : ReflectData.get().getSchema(pojo);
+            ReflectData reflectData = schemaDefinition.getAlwaysAllowNull() ? ReflectData.AllowNull.get()
+                    : ReflectData.get();
+            AvroSchema.addLogicalTypeConversions(reflectData, schemaDefinition.isJsr310ConversionEnabled());

Review comment:
       Can you explain why do we need this change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org