You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2018/02/01 02:28:55 UTC

[1/3] commons-rng git commit: Unused variable.

Repository: commons-rng
Updated Branches:
  refs/heads/master cb5f147e5 -> 0761c7c03


Unused variable.


Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/90ec4b13
Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/90ec4b13
Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/90ec4b13

Branch: refs/heads/master
Commit: 90ec4b134442e00e9a033982eadf11e9a37e33a4
Parents: cb5f147
Author: Gilles <er...@apache.org>
Authored: Thu Feb 1 01:55:05 2018 +0100
Committer: Gilles <er...@apache.org>
Committed: Thu Feb 1 01:55:05 2018 +0100

----------------------------------------------------------------------
 .../commons/rng/examples/sampling/UniformSamplingVisualCheck.java   | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-rng/blob/90ec4b13/commons-rng-examples/src/main/java/org/apache/commons/rng/examples/sampling/UniformSamplingVisualCheck.java
----------------------------------------------------------------------
diff --git a/commons-rng-examples/src/main/java/org/apache/commons/rng/examples/sampling/UniformSamplingVisualCheck.java b/commons-rng-examples/src/main/java/org/apache/commons/rng/examples/sampling/UniformSamplingVisualCheck.java
index 3a87990..b7c901c 100644
--- a/commons-rng-examples/src/main/java/org/apache/commons/rng/examples/sampling/UniformSamplingVisualCheck.java
+++ b/commons-rng-examples/src/main/java/org/apache/commons/rng/examples/sampling/UniformSamplingVisualCheck.java
@@ -58,7 +58,6 @@ public class UniformSamplingVisualCheck {
 
         final UniformSamplingVisualCheck app = new UniformSamplingVisualCheck();
 
-        long n = 0;
         while (true) {
             System.out.printf("%.16e\t", app.rng.nextDouble());
 


[2/3] commons-rng git commit: Reference.

Posted by er...@apache.org.
Reference.


Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/8de0c365
Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/8de0c365
Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/8de0c365

Branch: refs/heads/master
Commit: 8de0c3657a8d69992634092fdb51437a70b5dc43
Parents: 90ec4b1
Author: Gilles <er...@apache.org>
Authored: Thu Feb 1 03:25:08 2018 +0100
Committer: Gilles <er...@apache.org>
Committed: Thu Feb 1 03:25:08 2018 +0100

----------------------------------------------------------------------
 .../org/apache/commons/rng/sampling/distribution/package-info.java | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-rng/blob/8de0c365/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/package-info.java
----------------------------------------------------------------------
diff --git a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/package-info.java b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/package-info.java
index 1b75247..c98f99b 100644
--- a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/package-info.java
+++ b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/package-info.java
@@ -36,6 +36,8 @@
  *
  * Algorithms are described in e.g. Luc Devroye (1986), <a href="http://luc.devroye.org/chapter_nine.pdf">chapter 9</a>
  * and <a href="http://luc.devroye.org/chapter_ten.pdf">chapter 10</a>.
+ *
+ * This <a href="http://www.doc.ic.ac.uk/~wl/papers/07/csur07dt.pdf">paper</a> discusses Gaussian generators.
  */
 
 package org.apache.commons.rng.sampling.distribution;


[3/3] commons-rng git commit: Fix range.

Posted by er...@apache.org.
Fix range.


Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/0761c7c0
Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/0761c7c0
Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/0761c7c0

Branch: refs/heads/master
Commit: 0761c7c03a38be60956309a9cd59034de7aac88a
Parents: 8de0c36
Author: Gilles <er...@apache.org>
Authored: Thu Feb 1 03:26:39 2018 +0100
Committer: Gilles <er...@apache.org>
Committed: Thu Feb 1 03:26:39 2018 +0100

----------------------------------------------------------------------
 .../sampling/distribution/MarsagliaNormalizedGaussianSampler.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-rng/blob/0761c7c0/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/MarsagliaNormalizedGaussianSampler.java
----------------------------------------------------------------------
diff --git a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/MarsagliaNormalizedGaussianSampler.java b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/MarsagliaNormalizedGaussianSampler.java
index 626ba98..a20d3be 100644
--- a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/MarsagliaNormalizedGaussianSampler.java
+++ b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/MarsagliaNormalizedGaussianSampler.java
@@ -51,7 +51,7 @@ public class MarsagliaNormalizedGaussianSampler
                 final double y = 2 * nextDouble() - 1;
                 final double r2 = x * x + y * y;
 
-                if (r2 <= 1 && r2 != 0) {
+                if (r2 < 1 && r2 > 0) {
                     // Pair (x, y) is within unit circle.
                     final double alpha = Math.sqrt(-2 * Math.log(r2) / r2);