You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@freestoneinfotech.com> on 2016/04/26 10:56:50 UTC
Review Request 46674: RANGER-952 : Tagadmin user name should be
configurable in tagsync module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46674/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-952
https://issues.apache.org/jira/browse/RANGER-952
Repository: ranger
Description
-------
** Problem Statement :** Tagadmin user name should be configurable in tagsync module; Currently tag admin user 'rangertagsync' is being used to communicate with Ranger-admin.
** Proposed Solution :**
Added a property 'ranger.tagsync.dest.ranger.username' in ranger-tagsync-template.xml which will have tag admin user name and Tagsync module shall use mentioned username to sync tags to Ranger-admin.
Diffs
-----
tagsync/conf/templates/ranger-tagsync-template.xml 03bb3fa
tagsync/scripts/setup.py 4404cdc
tagsync/scripts/updatetagadminpassword.py 445d89b
tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java d14a9ce
tagsync/src/main/resources/ranger-tagsync-default.xml 131e319
tagsync/src/main/resources/ranger-tagsync-site.xml fe300b4
Diff: https://reviews.apache.org/r/46674/diff/
Testing
-------
**Steps Performed(with patch) : **
1. Installed Ranger Admin and Ranger Tagsync.
2. Created an internal user 'tagadmin1' at Ranger admin with 'Admin' role.
3. Stopped Ranger tagsync module and added value 'tagadmin1' for 'ranger.tagsync.dest.ranger.username'
4. Executed updatetagadminpassword.py to update 'tagadmin1' password in jceks file.
5. Started tag sync module.
**Expected behaviour :**
1. Ranger tagsync module should able to communicate to Ranger admin.
2. Ranger admin should authenticate 'tagadmin1' user.
**Actual behaviour :**
1. Ranger tagsync module was able to communicate to Ranger admin.
2. Ranger admin has authentication successful message for 'tagadmin1' user.
Thanks,
Pradeep Agrawal
Re: Review Request 46674: RANGER-952 : Tagadmin user name should be
configurable in tagsync module
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46674/#review131048
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On April 26, 2016, 8:56 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46674/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 8:56 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-952
> https://issues.apache.org/jira/browse/RANGER-952
>
>
> Repository: ranger
>
>
> Description
> -------
>
> ** Problem Statement :** Tagadmin user name should be configurable in tagsync module; Currently tag admin user 'rangertagsync' is being used to communicate with Ranger-admin.
>
>
> ** Proposed Solution :**
> Added a property 'ranger.tagsync.dest.ranger.username' in ranger-tagsync-template.xml which will have tag admin user name and Tagsync module shall use mentioned username to sync tags to Ranger-admin.
>
>
> Diffs
> -----
>
> tagsync/conf/templates/ranger-tagsync-template.xml 03bb3fa
> tagsync/scripts/setup.py 4404cdc
> tagsync/scripts/updatetagadminpassword.py 445d89b
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java d14a9ce
> tagsync/src/main/resources/ranger-tagsync-default.xml 131e319
> tagsync/src/main/resources/ranger-tagsync-site.xml fe300b4
>
> Diff: https://reviews.apache.org/r/46674/diff/
>
>
> Testing
> -------
>
> **Steps Performed(with patch) : **
> 1. Installed Ranger Admin and Ranger Tagsync.
> 2. Created an internal user 'tagadmin1' at Ranger admin with 'Admin' role.
> 3. Stopped Ranger tagsync module and added value 'tagadmin1' for 'ranger.tagsync.dest.ranger.username'
> 4. Executed updatetagadminpassword.py to update 'tagadmin1' password in jceks file.
> 5. Started tag sync module.
>
> **Expected behaviour :**
> 1. Ranger tagsync module should able to communicate to Ranger admin.
> 2. Ranger admin should authenticate 'tagadmin1' user.
>
> **Actual behaviour :**
> 1. Ranger tagsync module was able to communicate to Ranger admin.
> 2. Ranger admin has authentication successful message for 'tagadmin1' user.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>