You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sh...@apache.org on 2017/09/19 18:52:22 UTC
lucene-solr:feature/autoscaling: SOLR-11371: Removing nocommits
related to instantiating plugins from the blob store
Repository: lucene-solr
Updated Branches:
refs/heads/feature/autoscaling bb408c35a -> 2f94136a6
SOLR-11371: Removing nocommits related to instantiating plugins from the blob store
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/2f94136a
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/2f94136a
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/2f94136a
Branch: refs/heads/feature/autoscaling
Commit: 2f94136a69bf78855f877fd5d6795a0db80625e0
Parents: bb408c3
Author: Shalin Shekhar Mangar <sh...@apache.org>
Authored: Tue Sep 19 11:52:17 2017 -0700
Committer: Shalin Shekhar Mangar <sh...@apache.org>
Committed: Tue Sep 19 11:52:17 2017 -0700
----------------------------------------------------------------------
.../org/apache/solr/cloud/autoscaling/AutoScalingHandler.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/2f94136a/solr/core/src/java/org/apache/solr/cloud/autoscaling/AutoScalingHandler.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/cloud/autoscaling/AutoScalingHandler.java b/solr/core/src/java/org/apache/solr/cloud/autoscaling/AutoScalingHandler.java
index 38a2e1e..6ad84b8 100644
--- a/solr/core/src/java/org/apache/solr/cloud/autoscaling/AutoScalingHandler.java
+++ b/solr/core/src/java/org/apache/solr/cloud/autoscaling/AutoScalingHandler.java
@@ -459,7 +459,7 @@ public class AutoScalingHandler extends RequestHandlerBase implements Permission
if (op.hasError()) return currentConfig;
// validate that we can load the listener class
- // todo nocommit -- what about MemClassLoader?
+ // todo allow creation from blobstore
try {
container.getResourceLoader().findClass(listenerClass, TriggerListener.class);
} catch (Exception e) {
@@ -518,7 +518,7 @@ public class AutoScalingHandler extends RequestHandlerBase implements Permission
}
// validate that we can load all the actions
- // todo nocommit -- what about MemClassLoader?
+ // todo allow creation from blobstore
for (Map<String, String> action : actions) {
if (!action.containsKey(NAME) || !action.containsKey(CLASS)) {
op.addError("No 'name' or 'class' specified for action: " + action);