You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/01/16 03:20:07 UTC

[GitHub] dharders commented on issue #1085: Return update_seq and offset when update_seq is true and keys is set

dharders commented on issue #1085: Return update_seq and offset when update_seq is true and keys is set
URL: https://github.com/apache/couchdb/pull/1085#issuecomment-357843147
 
 
   Hi, PouchDB PR author here.
   
   PouchDB was missing `{ update_seq: true }` option, so we added it due to user request. One of our tests caught the `keys` failing case when `update_seq=true`. I agree that the `offset` and `update_seq` information does not make a great deal of sense in a sharded environment.
   
   Our main motivation is to match CouchDB API, so whatever you decide is best we will follow.
   
   If you decide that it is easier to update the documentation (for the `keys` case) then we are fine with that. Returning `null` is also fine. As long as the API matches the documentation we will make it work!
   
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services