You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by ve...@apache.org on 2011/01/05 23:26:55 UTC

svn commit: r1055665 - /webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/factory/OMLinkedListImplFactory.java

Author: veithen
Date: Wed Jan  5 22:26:55 2011
New Revision: 1055665

URL: http://svn.apache.org/viewvc?rev=1055665&view=rev
Log:
Throwing out some dead code that is only there for historical reasons.

Modified:
    webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/factory/OMLinkedListImplFactory.java

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/factory/OMLinkedListImplFactory.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/factory/OMLinkedListImplFactory.java?rev=1055665&r1=1055664&r2=1055665&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/factory/OMLinkedListImplFactory.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/factory/OMLinkedListImplFactory.java Wed Jan  5 22:26:55 2011
@@ -46,28 +46,12 @@ import org.apache.axiom.om.impl.llom.OMS
 import org.apache.axiom.om.impl.llom.OMTextImpl;
 
 import javax.xml.namespace.QName;
-import java.util.Hashtable;
-import java.util.Map;
 
 /** Class OMLinkedListImplFactory
  */
 public class OMLinkedListImplFactory implements OMFactory {
-
-    private static final String uriAndPrefixSeparator = ";";
-    
-    
-    // Pooling of OMNamespace objects is disabled.  See the comment in OMNamespace.
-    private static boolean POOL_OMNAMESPACES = false;
-    
     private final OMLinkedListMetaFactory metaFactory;
     
-    /**
-     * This is a map of namespaces with the namespace URI as the key and Namespace object itself as
-     * the value.
-     * OMFactories are shared across threads.  The Hashtable is necessary to prevent concurrent modification exceptions.
-     */
-    protected Map namespaceTable = new Hashtable(5);
-    
     public OMLinkedListImplFactory(OMLinkedListMetaFactory metaFactory) {
         this.metaFactory = metaFactory;
     }
@@ -186,27 +170,7 @@ public class OMLinkedListImplFactory imp
      * @return Returns OMNamespace.
      */
     public OMNamespace createOMNamespace(String uri, String prefix) {
-        // An OMNamespaceImpl consists of only two String objects;
-        // The overhead to create "yet another" key string and pool these
-        // small objects is unnecessary.  In addition,
-        // the objects are never freed from the pool, which means that the
-        // the table will grow very large over time.  For this reason, the
-        // pooling of OMNamespaces is disabbled.
-        
-        if (POOL_OMNAMESPACES) {
-            String key = uri;
-            if (prefix != null && prefix.length() > 0) {
-                key = key + uriAndPrefixSeparator + prefix;
-            }
-            OMNamespace existingNamespaceObject = (OMNamespace) namespaceTable.get(key);
-            if (existingNamespaceObject == null) {
-                existingNamespaceObject = new OMNamespaceImpl(uri, prefix);
-                namespaceTable.put(key, existingNamespaceObject);
-            }
-            return existingNamespaceObject;
-        } else {
-            return new OMNamespaceImpl(uri, prefix);
-        }
+        return new OMNamespaceImpl(uri, prefix);
     }
 
     /**