[GitHub] [spark] advancedxy commented on a diff in pull request #41196: [SPARK-43505][K8S] support env variables substitution and executor library path

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #41196:
URL: https://github.com/apache/spark/pull/41196#discussion_r1197323037


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala:
##########
@@ -71,7 +71,9 @@ private[spark] class KubernetesExecutorBuilder {
       new MountSecretsFeatureStep(conf),
       new EnvSecretsFeatureStep(conf),
       new MountVolumesFeatureStep(conf),
-      new LocalDirsFeatureStep(conf)) ++ userFeatures
+      new LocalDirsFeatureStep(conf),
+      new ReconstructEnvFeatureStep(conf)

Review Comment:
   this doesn't work as expected as spark wouldn't create other resource when building executor pod.
   
   Will fix and propose another solution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org