[GitHub] [arrow] pitrou commented on a diff in pull request #12657: ARROW-14821: [C++] Add ceil_is_strictly_greater and calendar_based_origin temporal round options (to mimic lubridate's date rounding)

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #12657:
URL: https://github.com/apache/arrow/pull/12657#discussion_r885557031


##########
python/pyarrow/_compute.pyx:
##########
@@ -905,10 +907,41 @@ class RoundTemporalOptions(_RoundTemporalOptions):
         "nanosecond".
     week_starts_monday : bool, default True
         If True, weeks start on Monday; if False, on Sunday.
-    """
-
-    def __init__(self, multiple=1, unit="day", week_starts_monday=True):
-        self._set_options(multiple, unit, week_starts_monday)
+    ceil_is_strictly_greater : bool, default False
+        If True return a rounded value that is strictly greater than the
+        input. For example: ceiling 1970-01-01T00:00:00 to 3 hours would

Review Comment:
   ```suggestion
           If True, ceil returns a rounded value that is strictly greater than the
           input. For example: ceiling 1970-01-01T00:00:00 to 3 hours would
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org