[incubator-ponymail] branch master updated: Attachments affect cluster id

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-ponymail.git


The following commit(s) were added to refs/heads/master by this push:
     new 388e90b  Attachments affect cluster id
388e90b is described below

commit 388e90bb261756ada7f489ed1ba198404a018d6f
Author: Sebb <se...@apache.org>
AuthorDate: Fri Aug 28 00:31:52 2020 +0100

    Attachments affect cluster id
---
 tools/generators.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/generators.py b/tools/generators.py
index 0fcffe2..54e39b4 100644
--- a/tools/generators.py
+++ b/tools/generators.py
@@ -151,6 +151,8 @@ def cluster(msg, body, lid, attachments):
     N.B. The id is not guaranteed stable - i.e. it may change if the message is reparsed. 
     The id depends on the parsed body, which depends on the exact method used to parse the mail.
     For example, are invalid characters ignored or replaced; is html parsing used?
+    The output also depends on attachment hashes, so any changes to attachment parsing
+    can also change the output. For example, the code now handles inline attachments.
 
     The following message fields are concatenated to form the hash input:
     - body as is if bytes else encoded ascii, ignoring invalid characters; if the body is null it is treated as an empty string